Opened 3 years ago

Closed 3 years ago

#18999 closed defect (fixed)

go-webrtc: fixes for 386

Reported by: dcf Owned by:
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: arlolra, serene Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In preparing a Gitian build of Snowflake for linux-386, I ran into architecture problems that are fixed by the attached patch.

The first just adds a webrtc-linux-386.pc, like already existed for linux-amd64 and darwin-amd64.

The second reduces the size of some static Cgo array bounds, to avoid this error:

configuration.go:228[/tmp/go-build928087590/github.com/keroserene/go-webrtc/_obj/configuration.cgo1.go:238]: type [1073741824]*_Ctype_char larger than address space

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by dcf

Status: newneeds_review

comment:2 Changed 3 years ago by arlolra

Resolution: fixed
Status: needs_reviewclosed

Thanks, merged.

FYI, the current magic static libraries are built with this change,
https://github.com/keroserene/go-webrtc/commit/707f2c77559318801771d88440c21f945a074107

Not sure if I documented that anywhere, but seems like you're on the road to producing one for 386 so good to note.

Note: See TracTickets for help on using tickets.