Changes between Initial Version and Version 1 of Ticket #19001, comment 15


Ignore:
Timestamp:
Aug 29, 2016, 1:57:09 AM (16 months ago)
Author:
dcf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19001, comment 15

    initial v1  
    55The repository history is a complete disaster, but I decided to just push it as it is to a side branch and we can clean it up later. We'll have to do a huge rebase anyway before merging to master. Here's [https://gitweb.torproject.org/user/dcf/tor-browser-bundle.git/diff/?h=snowflake-mac-1&id2=a83d3993eebbad215a81b991918b22bb3ca9bcef the diff] relative to the last working linux build.
    66
    7 At a high level, the main major changes are 1) using clang and libc++ to build libwebrtc, and 2) factoring out a separate gitian-webrtc.yml descriptor. These changes I'll probably port back to the linux descriptor. About the various other necessary hacks, the best thing I can say is they are finite in number. There was one [https://llvm.org/bugs/show_bug.cgi?id=28831 straight-up bug in CMake] that I reported upstream. I had to do some finessing of CFLAGS et al. because our clang and 10.7 SDK are a little older than what the build script expect. The build really expects you to be doing Mac builds using Xcode and I had to work around that assumption in a number of places, including a little bit of rewriting of ninja files. The biggest and ugliest part is [https://gitweb.torproject.org/user/dcf/tor-browser-bundle.git/tree/gitian/patches/webrtc-mac.patch?h=snowflake-mac-1 this patch] that gets applied directly to the webrtc sources.
     7At a high level, the main major changes are 1) using clang and libc++ to build libwebrtc, and 2) factoring out a separate gitian-webrtc.yml descriptor. These changes I'll probably port back to the linux descriptor. About the various other necessary hacks, the best thing I can say is they are finite in number. There was one [https://llvm.org/bugs/show_bug.cgi?id=28831 straight-up bug in libc++'s CMakeLists.txt] that I reported upstream. I had to do some finessing of CFLAGS et al. because our clang and 10.7 SDK are a little older than what the build script expect. The build really expects you to be doing Mac builds using Xcode and I had to work around that assumption in a number of places, including a little bit of rewriting of ninja files. The biggest and ugliest part is [https://gitweb.torproject.org/user/dcf/tor-browser-bundle.git/tree/gitian/patches/webrtc-mac.patch?h=snowflake-mac-1 this patch] that gets applied directly to the webrtc sources.