Opened 4 years ago

Closed 3 years ago

#19003 closed defect (fixed)

Make sure small networks can bootstrap without exits

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.2-alpha
Severity: Normal Keywords: must-fix-before-028-rc, CoreTorTeam201605, review-group-1 regression
Cc: Actual Points:
Parent ID: Points: small
Reviewer: arma Sponsor:

Description

#18050 made it impossible for directory servers in small networks to bootstrap without exits in the network.

We can fix that by assuming DirPort reachability in small networks without exits.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by teor

Status: newneeds_review

Please see my branch bug19003 in https://github.com/teor2345/tor.git

comment:2 Changed 4 years ago by nickm

Keywords: review-group-1 added

comment:3 Changed 4 years ago by nickm

Keywords: regression added

comment:4 Changed 4 years ago by arma

+ * If need_exit is false, return 0 if we can build internal paths.

Do you mean return 1 here?

teor: I just pushed a bug19003-try2 branch to my git. It contains this fix plus also some refactoring of your other change. If you agree that the refactoring doesn't break anything, I think we're all set here.

comment:5 in reply to:  4 Changed 4 years ago by teor

Status: needs_reviewmerge_ready

Replying to arma:

+ * If need_exit is false, return 0 if we can build internal paths.

Do you mean return 1 here?

teor: I just pushed a bug19003-try2 branch to my git. It contains this fix plus also some refactoring of your other change. If you agree that the refactoring doesn't break anything, I think we're all set here.

This looks good to me. Let's get it merged.

comment:6 Changed 4 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged it is.

comment:7 Changed 3 years ago by arma

Resolution: fixed
Status: closedreopened

comment:8 Changed 3 years ago by arma

Owner: set to teor
Status: reopenedassigned

comment:9 Changed 3 years ago by arma

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.