Make sure small networks can bootstrap without exits

#18050 (moved) made it impossible for directory servers in small networks to bootstrap without exits in the network.

We can fix that by assuming DirPort reachability in small networks without exits.

changed milestone to %Tor: 0.2.8.x-final

added CoreTorTeam201605 component::core tor/tor milestone::Tor: 0.2.8.x-final must-fix-before-028-rc owner::teor points::small priority::medium regression resolution::fixed review-group-1 reviewer::arma severity::normal status::closed type::defect version::tor 0.2.8.2-alpha labels

Please see my branch bug19003 in https://github.com/teor2345/tor.git

Trac:
Status: new to needs_review

Trac:
Keywords: N/A deleted, review-group-1 added

Trac:
Keywords: review-group-1 deleted, review-group-1 regression added

+ * If need_exit is false, return 0 if we can build internal paths.

Do you mean return 1 here?

teor: I just pushed a bug19003-try2 branch to my git. It contains this fix plus also some refactoring of your other change. If you agree that the refactoring doesn't break anything, I think we're all set here.

Replying to arma:

{{{

• • If need_exit is false, return 0 if we can build internal paths. }}} Do you mean return 1 here?

teor: I just pushed a bug19003-try2 branch to my git. It contains this fix plus also some refactoring of your other change. If you agree that the refactoring doesn't break anything, I think we're all set here.

This looks good to me. Let's get it merged.

Trac:
Status: needs_review to merge_ready

Merged it is.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Owner: N/A to teor
Status: reopened to assigned

Trac:
Resolution: N/A to fixed
Status: assigned to closed

closed

moved to tpo/core/tor#19003 (closed)