Authorities should log a more accurate message when reachability checks fail

Authorities check reachability even though they assume they are reachable:

May 10 01:31:46.000 [warn] Your server (52.27.2.173:8299) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
May 10 01:31:46.000 [warn] Your server (52.27.2.173:34237) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

We should improve these messages for authorities.

changed milestone to %Tor: unspecified

added annoyance component::core tor/tor easy logging milestone::Tor: unspecified parent::24403 points::0.2 priority::low severity::trivial status::new tor-relay type::defect usability version::tor 0.2.8.2-alpha labels

They also shouldn't try to test their own reachability, or should they?

Any objection to delaying this till 0.2.9? It doesn't seem severe.

It's really not that severe, is it?

All that happens is that authorities will test and report their own reachability:

[notice] Now checking whether ORPort (address redacted) and DirPort (address redacted) are reachable... (this may take up to 20 minutes -- look for log messages indicating success)
[info] consider_testing_reachability(): Testing reachability of my ORPort: (address redacted).

This might even be considered a feature - authorities on the public tor network should always have their reachability tests succeed, and chutney authorities set AssumeReachable, so they'll never see these messages.

We should eventually fix up the log messages that are triggered when reachability testing fails:

[info] circuit_testing_failed(): Our testing circuit (to see if your ORPort is reachable) has failed. I'll try again later.
[warn] Your server (address redacted) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
[warn] Your server (address redacted) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

Really, all we need to do is choose between this message for relays:

Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

and this message for authorities (auth_dir_any_non_hidserv()):

Authorities always publish directory documents, regardless of whether their ORPort and DirPort are reachable.

Trac:
Priority: Medium to Low
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.???
Points: 1 to 0.2
Keywords: TorCoreTeam201605, logging, must-fix-before-028-rc deleted, logging easy added
Severity: Normal to Trivial

Edited the summary and description to reflect the new purpose of the ticket.

Trac:
Summary: Authorities shouldn't warn about reachability to Authorities should log a more accurate message when reachability checks fail
Description: Authorities log these messages even though they assume they are reachable:

May 10 01:31:46.000 [warn] Your server (52.27.2.173:8299) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
May 10 01:31:46.000 [warn] Your server (52.27.2.173:34237) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

We should skip these messages for authorities, and any tors that are going to publish their descriptors anyway.

to

Authorities check reachability even though they assume they are reachable:

May 10 01:31:46.000 [warn] Your server (52.27.2.173:8299) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
May 10 01:31:46.000 [warn] Your server (52.27.2.173:34237) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

We should improve these messages for authorities.

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: logging easy deleted, tor-03-unspecified-201612, easy, logging added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: N/A deleted, tor-relay annoyance, usability added

Disowning tickets I don't intend to work on in the next 6 months.

Trac:
Owner: teor to N/A
Status: new to assigned

Mark all tickets that are assigned to nobody as "new".

Trac:
Status: assigned to new

Trac:
Parent: N/A to #24403 (moved)

changed time estimate to 1h 36m

moved to tpo/core/tor#19013 (closed)