Opened 3 years ago

Last modified 23 months ago

#19013 new defect

Authorities should log a more accurate message when reachability checks fail

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.8.2-alpha
Severity: Trivial Keywords: logging, easy, tor-relay annoyance, usability
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description (last modified by teor)

Authorities check reachability even though they assume they are reachable:

May 10 01:31:46.000 [warn] Your server (52.27.2.173:8299) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
May 10 01:31:46.000 [warn] Your server (52.27.2.173:34237) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

We should improve these messages for authorities.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by teor

They also shouldn't try to test their own reachability, or should they?

comment:2 Changed 3 years ago by nickm

Any objection to delaying this till 0.2.9? It doesn't seem severe.

comment:3 Changed 3 years ago by teor

Keywords: easy added; must-fix-before-028-rc TorCoreTeam201605 removed
Milestone: Tor: 0.2.8.x-finalTor: 0.2.???
Points: 10.2
Priority: MediumLow
Severity: NormalTrivial

It's really not that severe, is it?

All that happens is that authorities will test and report their own reachability:

[notice] Now checking whether ORPort (address redacted) and DirPort (address redacted) are reachable... (this may take up to 20 minutes -- look for log messages indicating success)
[info] consider_testing_reachability(): Testing reachability of my ORPort: (address redacted).

This might even be considered a feature - authorities on the public tor network should always have their reachability tests succeed, and chutney authorities set AssumeReachable, so they'll never see these messages.

We should eventually fix up the log messages that are triggered when reachability testing fails:

[info] circuit_testing_failed(): Our testing circuit (to see if your ORPort is reachable) has failed. I'll try again later.
[warn] Your server (address redacted) has not managed to confirm that its ORPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.
[warn] Your server (address redacted) has not managed to confirm that its DirPort is reachable. Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

Really, all we need to do is choose between this message for relays:

Relays do not publish descriptors until their ORPort and DirPort are reachable. Please check your firewalls, ports, address, /etc/hosts file, etc.

and this message for authorities (auth_dir_any_non_hidserv()):

Authorities always publish directory documents, regardless of whether their ORPort and DirPort are reachable.

comment:4 Changed 3 years ago by teor

Description: modified (diff)
Summary: Authorities shouldn't warn about reachabilityAuthorities should log a more accurate message when reachability checks fail

Edited the summary and description to reflect the new purpose of the ticket.

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-relay annoyance usability added

comment:9 Changed 23 months ago by teor

Owner: teor deleted
Status: newassigned

Disowning tickets I don't intend to work on in the next 6 months.

comment:10 Changed 23 months ago by teor

Status: assignednew

Mark all tickets that are assigned to nobody as "new".

Note: See TracTickets for help on using tickets.