Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19015 closed enhancement (implemented)

use logging framework other than java.util.logging

Reported by: iwakeh Owned by: iwakeh
Priority: High Milestone: CollecTor 1.0.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: ctip
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Choose a different logging framework. We're aiming at the slf4j and logback combination, which enables easier and more flexible configuration for operation of collector.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by iwakeh

Priority: MediumHigh
Status: newassigned

set to high as a prerequisite for #19018.

comment:2 Changed 3 years ago by iwakeh

Status: assignedneeds_review

Please review my branch.

It looks longish, but the fisrt commit replaces the logging statements etc. and the second deletes the unnecessary scripts and provides a changed INSTALL.md.

INSTALL.md is far from complete, but it shouldn't tell anything outdated anymore. It is still up for review and completion in #18734.

With this branch #19021 could be merged to master in the main repo.

comment:3 Changed 3 years ago by iwakeh

I'll also test it on my mirror.

comment:4 Changed 3 years ago by iwakeh

The mirror is logging fine; only added some minor tweaks to the top of the branch.
(added logging of errors to console, and some changes to the test policy for logback.)

Please review the latest, too.

comment:5 Changed 3 years ago by karsten

Looks good to me. Please find some trivial changes in my branch task-19051. If those look good, I'll merge. Thanks!

comment:6 Changed 3 years ago by iwakeh

All fine, only a typo that was in INSTALL.md before we touched it:

-relay descriptors:" is quite important.
+relay descriptors:" are quite important.

comment:7 Changed 3 years ago by karsten

Sure, added another commit for that. Pushed to master. Please close if nothing remains to be done here. Thanks!

comment:8 Changed 3 years ago by iwakeh

Resolution: implemented
Status: needs_reviewclosed

Thanks a lot!
Great to have this and the configuration improvements!

Closing.

comment:9 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.0.0

Added to milestone for first release.

Note: See TracTickets for help on using tickets.