Opened 4 years ago

Closed 4 years ago

#19023 closed defect (fixed)

Improve prop224 quality (montreal hackfest)

Reported by: asn Owned by:
Priority: Medium Milestone:
Component: Core Tor Version:
Severity: Normal Keywords: tor-spec, tor-hs
Cc: nickm, special Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


There are many XXXs and RDs in prop224 that need to be addressed. The montreal hackfest is a good time for design changes.

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by asn

Status: newneeds_review

Please see my branch prop224-montreal for some changes.


  • We address many XXXs, TODOs and the recently introduced RDs in prop224.
  • We do cross-certification of introduction point keys.
  • We clarify various parts of the proposal (crypto, and legacy cells)
  • Bump the key len in cells to 2 bytes.
  • Add a ToC.
  • Various other fixes.

comment:2 Changed 4 years ago by arma

-        "auth-key" SP "ed25519" SP certificate NL
+        "auth-key" SP "ed25519" NL certificate NL

I think you want to explain that the certificate has some 'begin public key' style headers and footers on it?

comment:3 Changed 4 years ago by arma

"a RSA signature" -> "an RSA signature"

comment:4 Changed 4 years ago by special

arma's comments are fixed by bca05ca2 on my prop224-montreal branch.

comment:5 Changed 4 years ago by asn

Resolution: fixed
Status: needs_reviewclosed

These spec changes got merged to torspec.git during the montreal hackfest.

More spec changes remain to be written, like the time period stuff. I'll update the [tor-dev] mailing list when these changes are ready.

Note: See TracTickets for help on using tickets.