Break rend_data_t into something that could looks like this (or maybe without a union...):
struct rend_data_t { uint32_t version; /* XXX: Maybe not necessary if our code flow doesn't * require us to learn the version through that data struct. */ union { hs_data_v2_t v2; hs_data_v3_t v3; } hs;};
Once we have such construction, we can use v3 with that data structure more cleanly.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Child items 0
Show closed items
No child items are currently assigned. Use child items to break down this issue into smaller parts.
Linked items 0
Link issues together to show that they're related.
Learn more.
This is the first building block for the entire HSDir support. I'm submitting a request for review so if we are satisfied with it, it will be the first commit of the upcoming branch for the entire implementation (#17238 (moved)). It might change slightly as we add more commits but the bulk of the work is here:
This is the first building block for the entire HSDir support. I'm submitting a request for review so if we are satisfied with it, it will be the first commit of the upcoming branch for the entire implementation (#17238 (moved)). It might change slightly as we add more commits but the bulk of the work is here:
I did an initial review here just to keep things rolling.
I will do more review here in the future.
Thanks for this. I've addressed your comments. See 3 new commits on top I pushed to the merge request. In particular, the addition of a new file for rend_data_t stuff.
I did an initial review here just to keep things rolling.
I will do more review here in the future.
Thanks for this. I've addressed your comments. See 3 new commits on top I pushed to the merge request. In particular, the addition of a new file for rend_data_t stuff.
Great stuff. I did another review on that same merge request. The merge request has been polluted with various unrelated changes from master, but hopefully it's still readable.
Code looks good here! I guess the next step here would be testing it with the current HS system.