prop224: Refactor rend_data_t so be able to use multiple HS version

[dgoulet]

Break rend_data_t into something that could looks like this (or maybe without a union...):

struct rend_data_t {
  uint32_t version; /* XXX: Maybe not necessary if our code flow doesn't
                     * require us to learn the version through that data struct. */
  union {
    hs_data_v2_t v2;
    hs_data_v3_t v3;
  } hs;
};

Once we have such construction, we can use v3 with that data structure more cleanly.

[dgoulet]

This is the _first_ building block for the entire HSDir support. I'm submitting a request for review so if we are satisfied with it, it will be the first commit of the upcoming branch for the entire implementation (#17238). It might change slightly as we add more commits but the bulk of the work is here:

​https://gitlab.com/dgoulet/tor/merge_requests/8

[asn]

Replying to dgoulet:

This is the _first_ building block for the entire HSDir support. I'm submitting a request for review so if we are satisfied with it, it will be the first commit of the upcoming branch for the entire implementation (#17238). It might change slightly as we add more commits but the bulk of the work is here:

​https://gitlab.com/dgoulet/tor/merge_requests/8

I did an initial review here just to keep things rolling.

I will do more review here in the future.

[dgoulet]

Replying to asn:

Replying to dgoulet:

​https://gitlab.com/dgoulet/tor/merge_requests/8

I did an initial review here just to keep things rolling.

I will do more review here in the future.

Thanks for this. I've addressed your comments. See 3 new commits on top I pushed to the merge request. In particular, the addition of a new file for rend_data_t stuff.

[asn]

Replying to dgoulet:

Replying to asn:

Replying to dgoulet:

​https://gitlab.com/dgoulet/tor/merge_requests/8

I did an initial review here just to keep things rolling.

I will do more review here in the future.

Thanks for this. I've addressed your comments. See 3 new commits on top I pushed to the merge request. In particular, the addition of a new file for rend_data_t stuff.

Great stuff. I did another review on that same merge request. The merge request has been polluted with various unrelated changes from master, but hopefully it's still readable.

Code looks good here! I guess the next step here would be testing it with the current HS system.

[dgoulet]

Removing this from the review group because this ticket patch is part of the big #17238.

[dgoulet]

Review and merge will happen in September.

[nickm]

see parent

[nickm]

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

[nickm]

These have sat in needs_revision for a few weeks at least. Removing from review-group-9, not adding to review-group-10.

[dgoulet]

The implementation is in parent ticket which is being reviewed so putting this one in Accepted state and once parent is merged, we can simply close.

[dgoulet]

Merged as part of #17238 in commit 8293356a.