Rip out client directory fetch instrumentation

In the distant past, weasel put in a feature where clients would track number of bytes they receive by what category of directory information, and then you could query the current sums via the dirport ("GET /tor/bytes.txt"). It went into 0.2.1.1-alpha I think (see git commits 01c1a355 and 716558a), but it didn't get a changelog entry or a trac ticket, and also it only works #if defined(INSTRUMENT_DOWNLOADS) || defined(RUNNING_DOXYGEN).

I don't think anybody is using it now, and nobody in the Montreal Meeting wanted to keep it, so it looks like we should simplify by removing it.

I am cc'ing weasel since it was his feature originally, and now he can speak up in favor of its life if he wants.

changed milestone to %Tor: 0.2.9.x-final

added 029-nickm-says-yes TorCoreTeam201605 component::core tor/tor milestone::Tor: 0.2.9.x-final owner::arma points::0.1 remaining priority::medium resolution::implemented review-group-2 reviewer::dgoulet severity::normal status::closed type::enhancement labels

Turns out there's a control-spec way of requesting this data too:

    "dir-usage"
      A newline-separated list of how many bytes we've served to answer
      each type of directory request. The format of each line is:
         Keyword 1*SP Integer 1*SP Integer
      where the first integer is the number of bytes written, and the second
      is the number of requests answered.

But that said, it simply returns "Not implemented" unless your Tor has the compile-time option enabled. So I think nobody is going to miss this option.

My task19035 branch removes these features.

Also see my task19035-spec branch in my torspec.

Trac:
Status: new to needs_review
Keywords: N/A deleted, 029-proposed added

Damian: will we break anything in your stem-land with this change?

Trac:
Cc: weasel to weasel, atagar, dgoulet

I don't mind having it removed.

Nothing that's been mentioned ('GET /tor/bytes.txt' or 'GETINFO dir-usage') is ringing any bells. Sounds fine to remove to me.

Trac:
Keywords: N/A deleted, 029-nickm-says-yes added

Trac:
Points: N/A to 0.1 remaining

Create a review-group-2 from (most of the) tickets in 0.2.8 or 0.2.9 or 029-nickm-says-yes listed as needs_review,

Trac:
Keywords: N/A deleted, review-group-2 added

setting owner

Trac:
Status: needs_review to assigned
Owner: N/A to arma

Trac:
Status: assigned to needs_review

Calling these included in 0.2.9 because the (remaining) amount of work should be very small.

Trac:
Keywords: 029-proposed deleted, N/A added
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final

Trac:
Keywords: N/A deleted, TorCoreTeam201605 added

This is failing to build:

src/or/directory.c: In function ‘handle_get_frontpage’:
src/or/directory.c:2875:72: error: unused parameter ‘args’ [-Werror=unused-parameter]
 handle_get_frontpage(dir_connection_t *conn, const get_handler_args_t *args)

Adding (void) args; at the beginning of the function seems to work well for me.

Some reference still exists that we could probably get rid off:

./orconfig.h +536 /* #undef INSTRUMENT_DOWNLOADS */
./src/or/or.h +20 #ifndef INSTRUMENT_DOWNLOADS
./src/or/or.h +21 #define INSTRUMENT_DOWNLOADS 1

The rest lgtm;

Trac:
Status: needs_review to needs_revision

Awesome. I have pushed some fixup! commits to my task19035 branch, along with a whitespace fix.

There is now an XXX029 question for Nick that I'd like his opinion on.

And there's a task19035-fixedup branch that is the one we'd want to merge.

Trac:
Status: needs_revision to needs_review

+/* XXX029 Nothing left here? Take out or leave in? */

Take it out, says I.

With that XXX029 removed, it's ready imo. Builds and test passes.

Putting that one in merge_ready.

Trac:
Status: needs_review to merge_ready

Also remove the configuration option because it does nothing now.

diff --git a/configure.ac b/configure.ac
index d7db0db..b5e4b2b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -33,8 +33,6 @@ CPPFLAGS="$CPPFLAGS -I\${top_srcdir}/src/common"
 #XXXX020 We should make these enabled or not, before 0.2.0.x-final
 AC_ARG_ENABLE(openbsd-malloc,
    AS_HELP_STRING(--enable-openbsd-malloc, [use malloc code from OpenBSD.  Linux only]))
-AC_ARG_ENABLE(instrument-downloads,
-   AS_HELP_STRING(--enable-instrument-downloads, [instrument downloads of directory resources etc.]))
 AC_ARG_ENABLE(static-openssl,
    AS_HELP_STRING(--enable-static-openssl, [link against a static openssl library. Requires --with-openssl-dir]))
 AC_ARG_ENABLE(static-libevent,