Opened 3 years ago

Last modified 22 months ago

#19069 new defect

When DisableNetwork is 1 but !circuit_enough_testing_circs(), we can still launch circuits

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client disablenetwork sponsor8-maybe needs-design bootstrap
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In consider_testing_reachability(), we check

  if (test_or && (!orport_reachable || !circuit_enough_testing_circs())) {

Once #18616 is merged, the first function will return 1 for orport_reachable when DisableNetwork is 1, so that bug will go away.

But it will remain the case that if !circuit_enough_testing_circs(), we will proceed to call circuit_launch_by_extend_info(), even when DisableNetwork is 1.

There are four places that call consider_testing_reachability():

  • circuitbuild.c:circuit_send_next_onion_skin()
  • circuituse.c:circuit_testing_opened()
  • main.c:directory_info_has_arrived()
  • main.c:check_for_reachability_bw_callback()

I think the middle two are safe, since they shouldn't happen while DisableNetwork is set.

I think the first one is iffy, since it's called from a bunch of places so I'm not sure, but given the name I hope it doesn't get called during DisableNetwork.

And I think the fourth one is bad news, since it gets called periodically and doesn't check DisableNetwork.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by teor

The final case could be the source of warnings users have reported about connection attempts while DisableNetwork is set.

comment:2 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 22 months ago by nickm

Keywords: tor-client disablenetwork sponsor8-maybe needs-design bootstrap added
Note: See TracTickets for help on using tickets.