Opened 3 years ago

Last modified 7 months ago

#19074 new defect

Mark fallback directories down when their key is wrong

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: tor-client bad-retry annoying infinite-loop bootstrap
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

arma says that we will happily retry fallback directories with the wrong key fingerprint. We can do two things to fix this:

  • mark fallback directories as down when their key fingerprint is wrong
  • cancel all pending connections to a fallback with the wrong key (perhaps in #18809) - this should be unlikely with 100 fallbacks

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by arma

You see in circuit_build_failed() where we call

      entry_guard_register_connect_status(n_chan_id, 0, 1, time(NULL));
      /* if there are any one-hop streams waiting on this circuit, fail
       * them now so they can retry elsewhere. */
      connection_ap_fail_onehop(n_chan_id, circ->build_state);

?

But you see the places in connection_or.c where we call entry_guard_register_connect_status(failed) without also calling connection_ap_fail_onehop()?

I think we want a separate function to do all the smart things we should do when we we just decided that a pending OR connection attempt isn't going to work, and then call that new function consistently.

comment:2 Changed 3 years ago by nickm

Parent ID: #18809

comment:3 Changed 3 years ago by teor

Keywords: must-fix-before-0283 must-fix-before-028-rc removed
Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final
Version: Tor: 0.2.8.1-alpha

This is mitigated by having 100 fallbacks in 0.2.8, so it's unlikely we'll try one with a bad key twice.

comment:4 Changed 3 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: isaremoved removed

comment:9 Changed 23 months ago by nickm

Keywords: tor-client bad-retry annoying infinite-loop bootstrap added

comment:10 Changed 7 months ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:11 Changed 7 months ago by neel

Cc: neel removed
Owner: neel deleted

comment:12 Changed 7 months ago by neel

Status: assignednew
Note: See TracTickets for help on using tickets.