[prop250] Fix a time parsing error on platforms with 32 bit time_t
On platforms with 32 bit time_t, tor can't parse some dates in 2038, and all dates after 2038. So using 2666 in test data doesn't work.
My branch sr-32bit on https://github.com/teor2345/tor.git fixes this issue, which is T9 from #16943 (moved).
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.2.9.x-final
changed milestone to %Tor: 0.2.9.x-final
Trac:
Status: new to assigned
Owner: N/A to teorTrac:
Status: assigned to needs_reviewCreate a review-group-2 from (most of the) tickets in 0.2.8 or 0.2.9 or 029-nickm-says-yes listed as needs_review,
Trac:
Keywords: N/A deleted, review-group-2 addedTrac:
Reviewer: N/A to nickmwait, nm, this is on prop250.
Trac:
Reviewer: nickm to N/A
Summary: Fix a time parsing error on platforms with 32 bit time_t to [prop250] Fix a time parsing error on platforms with 32 bit time_tFWIW, this is a patch on top of the prop250 branch.
I included this fix in my #16943 (moved) branch (see comment:72:ticket:16943). We can close this ticket once that gets merged.
For now I remove it from review-group-2, since it's part of the prop250 giant.
Trac:
Keywords: review-group-2 deleted, N/A addedI just cherry-picked asn's commit into the branch that I'll be submitting for review today. Putting this ticket as resolved since the review will now happen in the #16943 (moved) (or as asn puts it, the prop250 giant).
Trac:
Resolution: N/A to fixed
Status: needs_review to closed- Trac closed
closed
- Trac changed time estimate to 48m
changed time estimate to 48m
- Trac added 48m of time spent
added 48m of time spent
- Trac moved to tpo/core/tor#19125 (closed)
moved to tpo/core/tor#19125 (closed)