Opened 4 years ago

Closed 4 years ago

#19125 closed defect (fixed)

[prop250] Fix a time parsing error on platforms with 32 bit time_t

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, TorCoreTeam201605
Cc: Actual Points: 0.1
Parent ID: #16943 Points: 0.1
Reviewer: Sponsor:

Description

On platforms with 32 bit time_t, tor can't parse some dates in 2038, and all dates after 2038. So using 2666 in test data doesn't work.

My branch sr-32bit on https://github.com/teor2345/tor.git fixes this issue, which is T9 from #16943.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by nickm

Owner: set to teor
Status: newassigned

comment:2 Changed 4 years ago by nickm

Status: assignedneeds_review

comment:3 Changed 4 years ago by nickm

Keywords: review-group-2 added

Create a review-group-2 from (most of the) tickets in 0.2.8 or 0.2.9 or 029-nickm-says-yes listed as needs_review,

comment:4 Changed 4 years ago by nickm

Reviewer: nickm

comment:5 Changed 4 years ago by nickm

Reviewer: nickm
Summary: Fix a time parsing error on platforms with 32 bit time_t[prop250] Fix a time parsing error on platforms with 32 bit time_t

wait, nm, this is on prop250.

comment:6 Changed 4 years ago by asn

Keywords: review-group-2 removed

FWIW, this is a patch on top of the prop250 branch.

I included this fix in my #16943 branch (see comment:72:ticket:16943). We can close this ticket once that gets merged.

For now I remove it from review-group-2, since it's part of the prop250 giant.

comment:7 Changed 4 years ago by dgoulet

Resolution: fixed
Status: needs_reviewclosed

I just cherry-picked asn's commit into the branch that I'll be submitting for review today. Putting this ticket as resolved since the review will now happen in the #16943 (or as asn puts it, the prop250 giant).

Note: See TracTickets for help on using tickets.