Remove the environ configure check

See ticket:19139#comment:1 on why the environ variable configure check can probably be removed.

changed milestone to %Tor: 0.3.0.x-final

added component::core tor/tor milestone::Tor: 0.3.0.x-final priority::medium resolution::not a bug severity::trivial status::closed type::defect labels

It turns out the environ variable cannot be redeclared because of -Wredundant-decls. Instead i looked into why it was added and if it can be removed.

It was initially added in commit efb7b9dec135594718b765234bc1f745855f60d2 because (according to the comment) FreeBSD needed it. The man page (all the way back to FreeBSD 1.0) tells us otherwise. If someone could give the reasoning why FreeBSD requires declaring environ that would be helpful because i don't have a FreeBSD machine and cannot test it myself.

In commit bc66878bdea0250991fc99b2d023146f67a6f4bb the environ configure check was added because it gave redundant declaration warnings on Linux. These were the exact same warnings i got when testing redeclaring environ unconditionally.

Trac:
Milestone: N/A to Tor: 0.3.0.x-final
Status: new to needs_review

Add 0.3.0 needs_review items (and ones that haven't been in needs_revision for very long) to review-group-10.

Trac:
Keywords: N/A deleted, review-group-10 added

I don't actually see a patch here to review. Am I missing something? Let's turn it to needs_review when there is one?

Trac:
Status: needs_review to new

This ticket has been stuck on the following section.

If someone could give the reasoning why FreeBSD requires declaring environ that would be helpful because i don't have a FreeBSD machine and cannot test it myself.

IMO the environ configure can be removed because nobody has given reasons for it being necessary and all the documentation says it is defined by default.

Trac:
Keywords: review-group-10 deleted, N/A added

ticket19142 does the obvious thing here.

Trac:
Status: new to needs_review

LGTM

Trac:
Status: needs_review to merge_ready

merged!

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

On OpenBSD:

  CC       src/common/compat.o
src/common/compat.c: In function 'get_environment':
src/common/compat.c:2404: error: 'environ' undeclared (first use in this function)
src/common/compat.c:2404: error: (Each undeclared identifier is reported only once
src/common/compat.c:2404: error: for each function it appears in.)
*** Error 1 in . (Makefile:3699 'src/common/compat.o': @echo "  CC      " src/common/compat.o;depbase=`echo src/common/compat.o | sed 's|[^/...)

Trac:
Username: rubiate

Okay. Reverting this with 2a00110e5bd3592ff69e659681b9294285a98dd0 .

Thanks also for the documentation link as http://man.openbsd.org/?query=environ&apropos=0&sec=0&arch=default&manpath=OpenBSD-current .

Trac:
Status: closed to reopened
Resolution: implemented to N/A

Trac:
Status: reopened to closed
Resolution: N/A to not a bug

Sorry for the time wasted on my suggestion which didn't work out in the end.

The FreeBSD builds on the BSD buildbot also started failing on this so i took another look at the FreeBSD implementation. This time i looked at the printenv implementation and it shows on line 55 they also define environ.

However, i believe the environ check can be simplified and I've opened #21023 (moved) for that (and other checks).

closed

mentioned in issue #21023 (moved)

moved to tpo/core/tor#19142 (closed)

mentioned in issue tpo/core/tor#21023 (closed)