Opened 4 years ago

Last modified 2 years ago

#19174 needs_revision defect

libscrypt check fails when libscrypt requires libm

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client build autotools 032-unreached
Cc: nickm, isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

See #19161 for background.

When libscrypt requires libm, our current check fails to detect libscrypt. This caused a failure to build (#19161), which we fixed by not calling libscrypt_scrypt() unless that function was actually found.

But we still have a problem here: We would like to detect libscrypt in these cases, and actually use it as appropriate.

Isis and I wrote a solution in isis's branch bug19161_028, but it has some remaining infelicities, I think. Will transcribe those in a comment.

Child Tickets

Change History (13)

comment:1 Changed 4 years ago by nickm

Status: newneeds_revision

Comment on current branch status:

I worry that as written it will add -lm even in places where it isn't needed. Also, the current approach adds -lscrypt in places where it isn't needed, which isn't good either.

comment:2 Changed 4 years ago by nickm

Cc: isis added; isabela removed

darn, messed up the cc

comment:3 Changed 4 years ago by nickm

Component: - Select a componentCore Tor/Tor

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???

move some milestone-free tickets into 0.2.???

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-client build autotools added; 029-proposed removed
Milestone: Tor: unspecifiedTor: 0.3.2.x-final

comment:9 Changed 2 years ago by nickm

Has this been a problem in practice?

comment:10 Changed 2 years ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

comment:11 in reply to:  9 ; Changed 2 years ago by isis

Keywords: 032-unreached removed
Milestone: Tor: unspecifiedTor: 0.3.2.x-final

Replying to nickm:

Has this been a problem in practice?


It has no longer been a problem for me. (This may be because I have dedicated Qubes VMs for building tor, or it may be because something somewhere fixed the issue.) Should I close this?

comment:12 in reply to:  11 Changed 2 years ago by isis

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Replying to isis:

Oops, re-adding keywords/milestone which got nuked.

comment:13 Changed 2 years ago by nickm

IMO we can let it sit in tor-unspecified, and either handle it later, or close it when we do our grand library-detection revision.

Note: See TracTickets for help on using tickets.