Opened 3 years ago

Closed 3 years ago

#19187 closed task (fixed)

Backport popup related ASan crash fix to Tor Browser 6.x

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-crash, TorBrowserTeam201605R, GeorgKoppen201605
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It turns out that one of the crashes I found with ASan got already reported a couple of days earlier and fixed on trunk. The security rating indicates that Mozilla won't backport that patch to ESR 45. But we should do for safety's sake.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Summary: Backport popup related ASan crash to Tor Browser 6.xBackport popup related ASan crash fix to Tor Browser 6.x

comment:2 Changed 3 years ago by gk

Keywords: TorBrowserTeam201605R added; TorBrowserTeam201605 removed
Status: newneeds_review

bug_19187 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_19187) is up for review. I've tested in a build that the crash is gone.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Arthur is fine with the backport. Taking as well for 6.0.1 as commit e38872520658a519cca3c69e635cd5cb6d825d21 on tor-browser-45.1.1esr-6.0-1

Note: See TracTickets for help on using tickets.