Opened 3 years ago

Closed 3 years ago

#19216 closed defect (fixed)

Our approach to warnings leaves too few warnings with Clang.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 4
Parent ID: #19180 Points:
Reviewer: Sponsor: SponsorS-can

Description

For example, clang 3.7 reports itself as compatible with gcc 4.2, but it actually supports many warnings from later versions of gcc. We should just try to detect which warnings are supported.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by nickm

Status: newneeds_review

a74f3abc52ded6cb69b9272d8dac3f22528bd98d , which is part of my #19180 branch, fixes this. I manually inspected that I wasn't dropping any warnings -- but you might want to check too.

comment:2 Changed 3 years ago by cypherpunks

That commit only contains the changes file.

comment:3 Changed 3 years ago by nickm

d979da8b017989 is a fixup commit with the actual changes.

comment:4 Changed 3 years ago by nickm

and 1ee7cd459257bc is a fixup on the fixup to make it work right. :/

comment:5 in reply to:  4 Changed 3 years ago by cypherpunks

Replying to nickm:

and 1ee7cd459257bc is a fixup on the fixup to make it work right. :/

This made it work properly.

Also see #19220 for an IMO proper solution for preventing similar issues in the future.

comment:6 Changed 3 years ago by nickm

Actual Points: 4
Sponsor: SponsorS-can

comment:7 Changed 3 years ago by andrea

Status: needs_reviewmerge_ready

These look okay to me; I'll also post my review of #19180

comment:8 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged #19180. Thanks!

Note: See TracTickets for help on using tickets.