Opened 3 years ago

Closed 3 years ago

#19303 closed enhancement (implemented)

Revise {extend,create}_cell_format to use trunnel

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop220, ed25519, tor-crypto-identity, tor-ed25519-proto, TorCoreTeam201609
Cc: Actual Points: .5
Parent ID: #15056 Points: 1
Reviewer: Sponsor: SponsorU-must

Description

As part of the prop220 extend cell work, we'll be making these functions bigger. It's time to be safe and make them use trunnel.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by nickm

Component: - Select a componentCore Tor/Tor
Keywords: prop220 ed25519 tor-crypto-identity tor-ed25519-proto added
Milestone: Tor: 0.2.9.x-final
Owner: set to nickm
Sponsor: SponsorS-must
Status: newassigned

comment:2 Changed 3 years ago by nickm

Sponsor: SponsorS-mustSponsorU-must

comment:3 Changed 3 years ago by nickm

Keywords: TorCoreTeam201607 added

comment:4 Changed 3 years ago by nickm

Draft:

struct trn_create2_cell {
  u16 type;
  u16 datalen;
  u8 data[datalen];
};

struct trn_created2_cell {
  u16 datalen;
  u8 data[datalen];
};

const LS_IPV4 = 0x00;
const LS_IPV6 = 0x01;
const LS_RSA_ID = 0x02;
const LS_ED_KEY = 0x03;

struct trn_linkspec {
  u8 type;
  u8 len;
  union spec[type] with length len {
    LS_IPV4: u32 ipv4_addr;
    LS_IPV6: u8 ipv6_addr[16];
    LS_RSA_ID: u8 rsa_keyid[20];
    LS_ED_KEY: u8 ed25519_key[32];
    default: u8 data[];
  };
}

struct trn_extend2_cell {
  u8 nspec;
  struct trn_linkspec specs[nspec];
  struct trn_create2_cell create;
}

comment:5 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added; TorCoreTeam201607 removed

No further code or documentation will be written in July, due to time itself. (Leaving needs_revision tickets as-is)

comment:6 Changed 3 years ago by nickm

Keywords: TorCoreTeam201609 added; TorCoreTeam201608 removed

Move unfinished items assigned to me to september.

comment:7 Changed 3 years ago by nickm

Actual Points: .5
Resolution: implemented
Status: assignedclosed

Done as part of my 15056_wip branch.

Note: See TracTickets for help on using tickets.