Revise {extend,create}_cell_format to use trunnel

As part of the prop220 extend cell work, we'll be making these functions bigger. It's time to be safe and make them use trunnel.

changed milestone to %Tor: 0.2.9.x-final

added TorCoreTeam201609 actualpoints::.5 component::core tor/tor ed25519 milestone::Tor: 0.2.9.x-final owner::nickm parent::15056 points::1 priority::medium prop220 resolution::implemented severity::normal sponsor::U-must status::closed tor-crypto-identity tor-ed25519-proto type::enhancement labels

Trac:
Owner: N/A to nickm
Status: new to assigned
Keywords: N/A deleted, prop220, tor-crypto-identity, tor-ed25519-proto, ed25519 added
Milestone: N/A to Tor: 0.2.9.x-final
Component: - Select a component to Core Tor/Tor
Sponsor: N/A to SponsorS-must

Trac:
Sponsor: SponsorS-must to SponsorU-must

Trac:
Keywords: N/A deleted, TorCoreTeam201607 added

Draft:

struct trn_create2_cell {
  u16 type;
  u16 datalen;
  u8 data[datalen];
};

struct trn_created2_cell {
  u16 datalen;
  u8 data[datalen];
};

const LS_IPV4 = 0x00;
const LS_IPV6 = 0x01;
const LS_RSA_ID = 0x02;
const LS_ED_KEY = 0x03;

struct trn_linkspec {
  u8 type;
  u8 len;
  union spec[type] with length len {
    LS_IPV4: u32 ipv4_addr;
    LS_IPV6: u8 ipv6_addr[16];
    LS_RSA_ID: u8 rsa_keyid[20];
    LS_ED_KEY: u8 ed25519_key[32];
    default: u8 data[];
  };
}

struct trn_extend2_cell {
  u8 nspec;
  struct trn_linkspec specs[nspec];
  struct trn_create2_cell create;
}

No further code or documentation will be written in July, due to time itself. (Leaving needs_revision tickets as-is)

Trac:
Keywords: TorCoreTeam201607 deleted, TorCoreTeam201608 added

Move unfinished items assigned to me to september.

Trac:
Keywords: TorCoreTeam201608 deleted, TorCoreTeam201609 added

Done as part of my 15056_wip branch.

Trac:
Status: assigned to closed
Actualpoints: N/A to .5
Resolution: N/A to implemented

closed

changed time estimate to 8h

added 4h of time spent

moved to tpo/core/tor#19303 (closed)