Opened 4 years ago

Closed 4 years ago

#19323 closed enhancement (implemented)

controller: expose Download timer/timeout/retry information

Reported by: nickm Owned by: andrea
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-controller-extension TorCoreTeam201606
Cc: Actual Points: 2
Parent ID: #17284 Points: 1
Reviewer: Sponsor: SponsorS-can


Child Tickets

Attachments (1)

0001-Specify-download-GETINFO-queries-for-controller.patch (5.1 KB) - added by andrea 4 years ago.
Proposed controller spec patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by nickm

Component: - Select a componentCore Tor/Tor
Keywords: tor-controller-extension added
Milestone: Tor: 0.2.9.x-final
Sponsor: SponsorS-can
Type: defectenhancement

comment:2 Changed 4 years ago by nickm

Keywords: TorCoreTeam201606 added
Owner: set to andrea
Status: newassigned

comment:3 Changed 4 years ago by andrea

This ticket lacks a description beyond its summary; is the goal here to add controller queries for download_status_t objects for consensuses/descriptors/certificates?

comment:4 Changed 4 years ago by nickm

I think so. GETINFO would be logical.

comment:5 Changed 4 years ago by andrea

Actual Points: 2
Status: assignedneeds_review

This is now implemented including unit tests in my ticket19323_squashed branch.

comment:6 Changed 4 years ago by nickm

Status: needs_reviewneeds_revision
  • This needs a control-spec branch too
  • The documentation for digest_list_to_string() should say what the actual format is, if it's going to be exposed to the controller. ("a sequence of newline-terminated hex-encoded digests"?)
  • Ditto "download_status_to_string".
  • For next time: getinfo_helper_downloads_cert and friends would be cleaner and easier to test if the "parse what they want" and the "get the cert corresponding to that they want" parts were separate functions.

Otherwise looks good to me!

Changed 4 years ago by andrea

Proposed controller spec patch

comment:7 Changed 4 years ago by andrea

Status: needs_revisionneeds_review

comment:8 Changed 4 years ago by nickm

changes file lgtm. I can poke the documentation.

comment:9 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

8917c4f19fccbe26ccea78b7fdb6d4730ef017c4 is the documentation poke. Merging!

Note: See TracTickets for help on using tickets.