Opened 3 years ago

Last modified 2 years ago

#19333 new defect

Make node-selection functions testable and tested

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-route-testing
Cc: Actual Points:
Parent ID: Points: 4
Reviewer: Sponsor:

Description

This won't be that hard.

(Famous last words.)

We "just" need to make the part of the code that constructs the probability distribution for the known nodes separable from the part that chooses a node based on that probability distribution. Then, we need to write unit tests with an example nodelist to make sure that the correct properties are obeyed. As a part of that, we might want to make sure that every rule in the code is tested, and every rule in the code is in path-spec.

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by nickm

Sponsor: SponsorU-canSponsorU-must

comment:2 Changed 3 years ago by andrea

Owner: set to andrea
Status: newassigned

comment:3 Changed 3 years ago by nickm

Keywords: TorCoreTeam201607 added

comment:4 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added; TorCoreTeam201607 removed

No further code or documentation will be written in July, due to time itself. (Leaving needs_revision tickets as-is)

comment:5 Changed 3 years ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

comment:6 Changed 3 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Triaged out on December 2016 from 030 to 031.

comment:7 Changed 3 years ago by nickm

Sponsor: SponsorU-must

Clear sponsorS and sponsorU from open tickets in 0.3.1

comment:8 Changed 3 years ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: unspecified
Owner: andrea deleted

comment:9 Changed 2 years ago by nickm

Keywords: nickm-deferred-20161005 removed

comment:10 Changed 2 years ago by nickm

Keywords: triage-out-030-201612 removed

comment:11 Changed 2 years ago by nickm

Keywords: TorCoreTeam201608 removed

comment:12 Changed 2 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

Note: See TracTickets for help on using tickets.