Opened 3 years ago

Closed 3 years ago

#19361 closed enhancement (implemented)

Improve coverage on compat_*threads and workqueue

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-unit-tests, TorCoreTeam201606, review-group-3
Cc: Actual Points: .1
Parent ID: #16798 Points: .1
Reviewer: andrea Sponsor: SponsorS-can

Description

See my branch thread_coverage. It solves some but not all of #16798

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by nickm

Status: newneeds_review
Type: defectenhancement

comment:2 Changed 3 years ago by nickm

Keywords: TorCoreTeam201606 added

comment:3 Changed 3 years ago by cypherpunks

Wouldn't it be easier to maintain if all workqueue tests are in one script?

comment:4 Changed 3 years ago by nickm

Keywords: review-group-3 added

Move some tickets into review-group-3: they are in 0.2.9, and they are needs_review.

comment:5 Changed 3 years ago by andrea

Reviewer: andrea

comment:6 Changed 3 years ago by nickm

If you're keen to try gitlab for reviewing something, I've made a merge request for this one as https://gitlab.com/nickm_tor/tor/merge_requests/3

comment:7 Changed 3 years ago by andrea

Status: needs_reviewmerge_ready

Read through in gitlab, all looks fine to me.

comment:8 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Thanks; merged!

Note: See TracTickets for help on using tickets.