Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19373 closed enhancement (implemented)

write test that checks the default collector.properties

Reported by: iwakeh Owned by: iwakeh
Priority: Medium Milestone: CollecTor 1.0.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: ctip
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

write test that checks the default collector.properties

verify keys and value types.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by iwakeh

Status: newassigned

comment:2 Changed 3 years ago by iwakeh

Status: assignedneeds_review

Please review my branch.

comment:3 Changed 3 years ago by karsten

Status: needs_reviewneeds_revision

Hmm, I'll have to investigate more tomorrow, but it seems like the in/ directory with bridge descriptor tarballs keeps this new test really busy. It just "hangs" at:

~/src/collector$ ant test
Buildfile: /Users/karsten/src/collector/build.xml

init:

compile:

compile-tests:

test:
    [junit] Testsuite: org.torproject.collector.MainTest

Whereas moving that directory away makes the test run really fast.

So, I guess the test should not depend on what's in the local directory. Can you change that?

comment:4 Changed 3 years ago by iwakeh

I guess that is due to the 'smokeTest' and that it is just working on the contents of the 'in' dir -- not hanging.
That's an old test.

Could you try just the new properties file test? Or change the path pointing at the 'in' dir or remove the 'in' directory momentarily?

If it works, there should be a new issue for the other test behavior.

comment:5 Changed 3 years ago by karsten

Right, that issue was unrelated to the new test. Tweaked a few trivial whitespace issues and pushed to master. Can you open a new issue for the other test behavior, please? Thanks!

comment:6 Changed 3 years ago by iwakeh

Resolution: implemented
Status: needs_revisionclosed

Thanks!

The new issue is #19641

Closing.

comment:7 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.0.0

Added to milestone for first release.

Note: See TracTickets for help on using tickets.