Opened 3 years ago

Last modified 2 years ago

#19379 new enhancement

Consider adding even more compiler warnings, even when they require code changes.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: gcc-warnings technical-debt
Cc: Actual Points:
Parent ID: Points: parent
Reviewer: Sponsor:

Description

Some of these warnings _might_ be worth adding, either globally or selectively, but they would require a significant amount of effort to modify our code. (I already got the easy cases with #19180, I think.)

  cast-qual (4.6)

    Rationale: triggers everywhere, even in some pretty normal C.  Would
    be nice to have it trigger less, but would need to blow up a bunch
    of API things.  Bigger project.

  conversion (4.6)

    Rationale: triggers all over.  Probably wrong code in some
    cases, but careful thought needed in most Bigger project.

  sign-conversion (4.6)

    Triggers ALL OVER.  Quite possibly a bug in some cases, though.
    Bigger project.

  cast-align (3)
    We already do this safely. Need to re-test on a system with
    stronger-than-intel alignment rules, though.

  shadow (3)
    mistake; worth fixing.

  switch-default (3)
   Not sure this is a good idea; someof these look like mistakes,
   but some don't.

  assign-enum (clang)
   triggers all over; worth fixing.

  conditional-uninitialized (clang)
   triggers all over; not sure whether this is worth fixing.

Child Tickets

TicketTypeStatusOwnerSummary
#18902defectclosednickmAvoid variable shadowing in Tor

Change History (5)

comment:1 Changed 3 years ago by nickm

Keywords: gcc-warnings added

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by nickm

Keywords: technical-debt added
Note: See TracTickets for help on using tickets.