Opened 3 years ago

Last modified 2 years ago

#19380 new defect

Hand-audit compiler warning results which we wouldn't want to have on-by-default.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: gcc-warnings technical-debt paranoia safety warnings
Cc: Actual Points:
Parent ID: Points: parent
Reviewer: Sponsor:

Description

These warnings aren't definitely indicative of bugs in our code, and don't seem to be possible for us to fix in all cases. Still, it might be worth auditing all the cases where these warnings trigger, since they _might_ indicate bugs or possible areas of improvement.

  strict-overflow=3...5 (4.2)

    Behaves pretty differently on different GCC versions.

    We get warnings for just about every case where we have pointer
    math in an addition. That seems nutty.

  padded (3)
    Not a mistake.  Worth looking over for hand-audit purposes, but mostly
    harmless.

  unsafe-loop-optimizations (4.1)
    Worth hand-auditing, but triggers on every kind of interesting for loop.

  covered-switch-default
    Usually this is defensive programming, but it could be a mistake
    in some cases, or could cover up future mistakes?

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Keywords: gcc-warnings added

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by nickm

Keywords: technical-debt paranoia safety warnings added
Note: See TracTickets for help on using tickets.