Okay, it looks like we ran out of tickets for the 1.3.0 release. Yay!
Please take a look at my task-19398 branch for a few release preparation commits and give this pre-release tarball some testing, which is also what I'm currently doing. If there are no issues, it'll become the 1.3.0 release.
Trac: Status: new to needs_review Cc: N/Ato iwakeh
I attached a patch for the very few checkstyle complaints left after your clean-up work on #19574 (moved)
The two remaining non-javadoc need more work and should not be hurried.
There are also some minor changes that I just could not resist to do now.
Please review.
Patch looks good, merged to master, together with my earlier changes which I assume looked okay to you, but without the bump to 1.3.0-dev.
So, we're down to three checkstyle complaints? Maybe we should simply resolve those before putting out the release, so that we don't have to think about putting out the next release just yet. We don't have to do this in a hurry. It doesn't hurt anyone to delay the release a few more days. I'll start looking into those issues tomorrow, unless you do it first.
PS. I still really dislike the 'DescripTor' name. metrics-lib is a lot less confusing. The word 'Descriptor' already has a meaning and it's not this.
Thanks, atagar, for the hint to the missing shared randomness stuff! Much appreciated.
And thanks for sharing your thoughts on the name DescripTor. I moved that discussion to #19616 (moved), because this ticket is only for the release of $java-tor-descriptor-parsing-library version 1.3.0.
Please review my branch. (Branch optimistically named '*-final').
I actually found a useful comment for the javadoc. But, the reason for the comment is problematic from a design point of view. There shouldn't be two interfaces declaring the very same method; there should be a more structured hierarchy for the interfaces, too. I'll open a new issue for that. (#19640 (moved))
I cannot find the shiny new javadoc in the tarball. (#16873 (moved))
The javadoc jar was missing in 1.2.0, too.
It seems we simply forgot to add the javadoc jar task.