Opened 8 years ago

Closed 5 years ago

#1940 closed defect (wontfix)

Check should warn users who are not using Torbutton.

Reported by: mikeperry Owned by: Sebastian
Priority: Medium Milestone:
Component: Applications/Tor Check Version:
Severity: Keywords:
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Sorry nick, didn't know who else to give this too and our "vendibles" pages are not easy to find.

Anyway, we have waaay too many users showing up in #tor and using a dumb browser, and studies indicate that 20% of our users use Torbutton (see bug #1801).

Many of them test their browsers on We should provide a link to the TorButton and Tor Warning pages if does not detect a Torbutton user agent.

I can provide tests we can use to detect this generally while Tor is enabled.

Child Tickets

Change History (12)

comment:1 Changed 8 years ago by mikeperry

Owner: changed from nickm to sebastian
Status: newassigned

comment:2 Changed 8 years ago by mikeperry

Owner: changed from sebastian to Sebastian

comment:3 Changed 8 years ago by Sebastian

I'd be happy to tackle this in oct or so. What kind of tests do you have in mind, and where are they?

comment:4 Changed 8 years ago by mikeperry

I believe you should be able to inspect that window.tb_hooks_run is true in the javascript. It might be undefined. The proper check is:

if (typeof(window.tb_hooks_ran) === "boolean") { user_is_torbutton(); }

You need to do this in page javascript. Users who do not have javascript enabled should be informed that they are doing better than most, but they still should have torbutton installed anyways.

comment:5 Changed 8 years ago by mikeperry

There's two underscores before tb_hooks_ran and after window.

comment:6 Changed 8 years ago by Sebastian

hm ok. I'm not 100% sure how to make the non-js warning work without flashing the notice at users while the page is loading, but I'm sure I can figure something out.

comment:7 Changed 8 years ago by Sebastian

rransom suggested the noscript tag which I had completely forgotten about by now. Works like a charm.

comment:8 Changed 7 years ago by rransom

How should this ticket be closed?

comment:9 Changed 7 years ago by Sebastian

not at all until it's done?

comment:10 Changed 6 years ago by arma

Mike, can we close this as a won't-do, since many users have moved to TBB by now?

(We also try to make it hard for remote websites to determine if we're using Torbutton, but maybe that's not enough of a reason by itself.)

comment:11 Changed 5 years ago by arlolra

Is this still relevant?

comment:12 Changed 5 years ago by arlolra

Resolution: wontfix
Status: assignedclosed
Note: See TracTickets for help on using tickets.