Opened 3 years ago

Closed 3 years ago

#19424 closed defect (fixed)

remove hard coded paths and set default properties to values used on the main CollecTor instance

Reported by: iwakeh Owned by: iwakeh
Priority: High Milestone: CollecTor 1.0.0
Component: Metrics/CollecTor Version:
Severity: Minor Keywords: ctip
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

... and scan code base for other missed hard coded paths; e.g.
File ... = new File("stats"); should be
File ... = config.getPath(Key.StatsPath).toFile();.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by iwakeh

Status: newassigned

comment:2 Changed 3 years ago by iwakeh

Also search for other hard-coded paths.

Known places:
CreateIndexJson

comment:3 Changed 3 years ago by iwakeh

Quote from #19615

  • It seems that collector.properties uses different paths for formerly hard-coded paths as new defaults. Ideally, defaults should be exactly the same as before.

The setting should be changed to the initial defaults.

Last edited 3 years ago by iwakeh (previous) (diff)

comment:4 Changed 3 years ago by iwakeh

Summary: remove hard coded "stats" directoriesremove hard coded paths and set default properties to values used on the main CollecTor instance

comment:5 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.0.0

Added to first release milestone.

comment:6 Changed 3 years ago by iwakeh

Priority: LowHigh
Status: assignedneeds_review

Please review this commit, the one before that sets the latest descriptor release 1.3.0 as dependency.

Please also review and if necessary correct the paths in collector.properties.

Set to high, b/c I'd like to base the scheduler changes on this commit.

comment:7 Changed 3 years ago by karsten

Status: needs_reviewmerge_ready

Looks good, please find my branch task-19424 for three trivial fixes. Should I merge to master, and should I close this ticket afterwards?

comment:8 Changed 3 years ago by iwakeh

Thanks, that's fine. Please close after merge.

(I usually order Exceptions alphabetically, but ordering them according to available space is ok.)

comment:9 in reply to:  8 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Replying to iwakeh:

Thanks, that's fine. Please close after merge.

Merged.

(I usually order Exceptions alphabetically, but ordering them according to available space is ok.)

Ah, good point. Well, I didn't change this back now, because I don't think we're ordering exceptions very systematically anyway. And it probably doesn't matter much.

Closing. Thanks!

Note: See TracTickets for help on using tickets.