Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19449 closed enhancement (implemented)

Remove --disable-transparent configure option?

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: *@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Right now --enable-transparent is the default in ./configure.

I don't know of anyplace that disables it.

And that means that if there's any place that fails to build with it enabled, we would have heard about it, right?

So, the only possible remaining reason to disable it is if we don't want that extra code in Tor, for security reasons? Are there libraries that we choose not to link if it's disabled? Or is it just a couple of lines of code that we run or don't run?

(I noticed this option again while noticing that FreeBSD's Tor port ( https://trac.torproject.org/projects/tor/attachment/ticket/7734/FreeBSD_Tor_port_config.png ) gives the user the option of choosing --disable-transparent, along with other things like --enable-bufferevents and --enable-instrument-downloads that are distractions at best and downright dangerous sometimes.)

Child Tickets

Attachments (1)

0001-Fix-19449-Remove-disable-transparent-configure-optio.patch (2.4 KB) - added by U+039b 3 years ago.
Proposed patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by U+039b

Cc: *@… added

comment:2 Changed 3 years ago by nickm

+1 to removing the --disable-transparent option.

Roger, you might also like this temporary spreadsheet, where we started trying to think about what other options we might like to rip out: https://docs.google.com/spreadsheets/d/1Np1vBm0jSvUqxwaQdhkqDmYWxe4E3RO0R5RoRMtpkQQ/edit?usp=sharing .

comment:3 Changed 3 years ago by arma

I began to start on a patch for this one, and it quickly became clear that whoever writes this patch needs to understand basic auto* voodoo -- it isn't just a matter of removing a few lines.

Changed 3 years ago by U+039b

Proposed patch

comment:4 Changed 3 years ago by U+039b

Status: newneeds_review

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.9.x-final
Status: needs_reviewmerge_ready

This looks okay with me .. just need a changes file. I'll add one when I merge, unless somebody else writes one first.

comment:6 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

comment:7 Changed 3 years ago by yurivict271

Why not make it at least torrc-enabled?

Last edited 3 years ago by yurivict271 (previous) (diff)

comment:8 in reply to:  7 Changed 3 years ago by cypherpunks

Replying to yurivict271:

Why not make it at least torrc-enabled?

It is torrc-enabled as stated by the manual and it is disabled by default.

Note: See TracTickets for help on using tickets.