Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#1947 closed enhancement (fixed)

replace bwconnrate/burst consensus params with new names

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: #1750 Points:
Reviewer: Sponsor:

Description

#1830 (fixed in 0.2.2.15-alpha) addressed a bug in how relays running Tor 0.2.2.7-alpha through 0.2.2.14-alpha handle the bwconnrate and bwconnburst consensus params.

Now that we understand the bug better, those two consensus params should be verboten until 0.2.2.14-alpha is obsolete.

So piece one: note in dir-spec.txt about the old behavior of the broken params (apparently undocumented so far).

Piece two: come up with new names that we can use instead, and note them in dir-spec.

Piece three: teach Tor relays to read those new names instead. Should be an easy fix:
connection_or.c: (int)networkstatus_get_param(NULL, "bwconnrate",
connection_or.c: (int)networkstatus_get_param(NULL, "bwconnburst",

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by arma

As for piece two, "perconnbwrate" and "perconnbwburst" seem like plausible choices. They are the same as the config option names. The overlap could either be considered a feature or a bug; I don't have strong feelings there.

comment:2 Changed 8 years ago by arma

Status: newneeds_review

I might have just pushed a bug1947 branch to my public git.

comment:3 Changed 8 years ago by Sebastian

Looks good

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Fine by me. Merging.

comment:5 Changed 6 years ago by nickm

Keywords: tor-relay added

comment:6 Changed 6 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.