Opened 3 years ago

Closed 3 years ago

#19484 closed defect (fixed)

nsAppRunner Breaks Orfox build

Reported by: amoghbl1 Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201607R
Cc: mcs, brade, arthuredelstein, zenitur Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

toolkit/xre/nsAppRunner.cpp breaks the Orfox build with the error attached to this ticket.

Child Tickets

Attachments (1)

error.txt (10.9 KB) - added by amoghbl1 3 years ago.
Error log

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by amoghbl1

Attachment: error.txt added

Error log

comment:1 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201606R added

comment:2 Changed 3 years ago by mcs

Status: newneeds_review

comment:3 Changed 3 years ago by gk

Cc: arthuredelstein added

Looks good to me.

comment:4 Changed 3 years ago by gk

Cc: zenitur added

#19484 is a duplicate.

comment:5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201607R added; TorBrowserTeam201606R removed

comment:6 Changed 3 years ago by mcs

amoghbl1: Does the patch that I pointed to in comment:1 fix this compile failure for you?

comment:7 in reply to:  4 Changed 3 years ago by gk

Replying to gk:

#19484 is a duplicate.

This is actually #19516.

comment:8 Changed 3 years ago by amoghbl1

mcs: Yup, this fixes the compile failure for me.

comment:9 Changed 3 years ago by arthuredelstein

Looks good to me as well.

comment:10 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, this is fixed on tor-browser-45.2.0esr-6.0-1 and tor-browser-45.2.0esr-6.5-1 now (commit 3cf0ed64dc038b41605bf6c9d5e59bdeddb9e9bc and 1ca4e649547a905449f81f154fa3055a8364d1f3).

Note: See TracTickets for help on using tickets.