Opened 3 years ago

Closed 3 years ago

#19489 closed defect (fixed)

dir-spec.txt: Clarify identity key

Reported by: twim Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Specify which key we exactly use.

Child Tickets

Attachments (2)

0001-Clarify-what-the-identity-key-it-is.patch (978 bytes) - added by twim 3 years ago.
0001-Clarify-what-the-identity-key-it-is.2.patch (1.1 KB) - added by twim 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by twim

Status: newneeds_review

comment:2 Changed 3 years ago by twim

By the way, what's the point of including SHA1 has here?

comment:3 Changed 3 years ago by nickm

Status: needs_reviewneeds_revision

The correction is wrong. The first 20-byte field is a SHA1 hash of the RSA identity key. Is there something that made you think it was the Ed25519 identity key?

comment:4 Changed 3 years ago by twim

The correction is wrong. The first 20-byte field is a SHA1 hash of the RSA identity key.

OK, I see.

Is there something that made you think it was the Ed25519 identity key?

Yes, we do sign non-RSA identity keys (Ed25519 or others in the future) and it's unclear what keys we also need to sign here (the term "identiy key" is pretty ambiguous). It should be specified that it's the SHA1 of the "signing-key" then, I guess.

comment:5 Changed 3 years ago by twim

  • Fixed the indentation broken by me and also clarified what "Ed25519 identity key" is.

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-final
Status: needs_revisionneeds_review

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

sure; seems fine. Merged. Thanks!

Note: See TracTickets for help on using tickets.