Opened 4 years ago

Closed 4 years ago

#19492 closed defect (fixed)

dir-spec.txt: Simplify router-sig-ed25519 description

Reported by: twim Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There is new type of remark that simplifies description of the fields. Let's apply it.

Child Tickets

Attachments (1)

0001-Simplified-router-sig-ed25519-descripton.patch (1.1 KB) - added by twim 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by twim

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.9.x-final

comment:3 Changed 4 years ago by cypherpunks

s/identity-25519/identity-ed25519/

comment:4 in reply to:  3 Changed 4 years ago by twim

Replying to cypherpunks:

s/identity-25519/identity-ed25519/

Thanks, fixed!
Since I've copy-pasted it from other fields the this typo is present there as well. See #19500.

comment:5 Changed 4 years ago by twim

Type: enhancementdefect

comment:6 Changed 4 years ago by arma

Hm! So, "required when identity-ed25519 is present" makes sense to me. But that also makes it sound sort of like you could have this line even if there's no identity-ed25519 line. But later it says

The signing key in the identity-ed25519 certificate MUST
be the one used to sign the document.

So should we also clarify that you can't have one of these unless the identity-ed25519 line is present?

comment:7 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

applied and extended based on arma's comment

Note: See TracTickets for help on using tickets.