Opened 3 years ago

Closed 3 years ago

#19499 closed defect (fixed)

Compile time warnings with OpenSSL 1.1.0-pre6-dev (aka master).

Reported by: yawning Owned by: yawning
Priority: High Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.4-rc
Severity: Normal Keywords: tor-core crypto
Cc: Actual Points:
Parent ID: #19429 Points: 0.5
Reviewer: Sponsor:

Description

They changed a bunch of function prototypes since I wrote the code for #19406 to constify arguments passed to their RSA/DH accessors of doom.

This is trivial to fix, and should probably be done for the 0.2.8.x stable release assuming we intend to support OpenSSL 1.1.0 if it is declared stable prior to the 0.2.9.x getting out the door.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by yawning

Parent ID: #19429

comment:2 Changed 3 years ago by yawning

Status: newneeds_review

https://git.schwanenlied.me/yawning/tor/src/bug19499

Against maint-0.2.8 (unless I screwed up when branching). To be fair, I probably should have used const to begin with...

comment:3 Changed 3 years ago by nickm

Priority: MediumHigh

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged

Note: See TracTickets for help on using tickets.