Opened 3 years ago

Last modified 3 years ago

#19511 new defect

Drop #16488 patch

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-obsolete, TorBrowserTeam201607
Cc: gk, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Our #16488 patch was intended to hide the Sign in to Sync button in the hamburger menu. Unfortuately, reviewers at Mozilla weren't sure it was a good idea, and then it stopped working correctly when I rebased to FF45ESR.

We introduced torbutton patch #18743 instead. So I believe we can revert (or remove) our #16488 patch from tor-browser.git.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Cc: gk mcs brade added

Sounds like a good idea to me.

comment:2 Changed 3 years ago by mcs

Yes, this approach seems OK to me.

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201607 added; TorBrowserTeam201606 removed
Note: See TracTickets for help on using tickets.