Opened 3 years ago

Closed 2 years ago

#19538 closed enhancement (wontfix)

Replace raster glyphicons with vector icons for flags

Reported by: twim Owned by: phw
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Vector icons looks way better than tiny PNGs (especially on bigger screens).
I took ones from Font Awesome and included them. As a bonus there are some nice accessibility features in it.

Child Tickets

TicketTypeStatusOwnerSummary
#19539enhancementclosedphwAdd red/green circles to indicate uptime/downtime

Change History (9)

comment:1 Changed 3 years ago by twim

Status: newneeds_review

comment:2 Changed 3 years ago by twim

Resolution: wontfix
Status: needs_reviewclosed

comment:3 Changed 3 years ago by karsten

Resolution: wontfix
Status: closedreopened

Hmm, what's the reason for closing this ticket? Maybe it's something that somebody else wants to pick up? Or is there a technical reason? Re-opening for now to not lose track of it.

comment:4 Changed 3 years ago by twim

Sorry, I thought that I've lost this branch and this ticket is not useful anymore. :\
The relevant branch is fontawesome at https://github.com/nogoegst/atlas.

comment:5 Changed 3 years ago by cypherpunks

This doesn't play nicely with security set to high.

comment:6 Changed 2 years ago by irl

Status: reopenedneeds_information

If this cannot work with security set to high, I think we should abandon this idea. Is there a workaround?

comment:7 Changed 2 years ago by cypherpunks

It doesn't work on the high security level because it blocks custom fonts (which Font Awesome is). Similarly the graphs are blocked because they use SVG which is also disabled on the high security level. Instead it shows the No data available image which is incorrect in that case but that's something for another ticket.

The symbols turn into tofu which isn't a problem on the details page because each icon has a label next to it. However, in the search results there are no labels so there's only tofu. One solution would be to test whether custom fonts and SVG is supported and use suitable replacements. This would also help #13354 because the proposed country flags also use SVG.

comment:8 in reply to:  7 Changed 2 years ago by teor

Replying to cypherpunks:

...
One solution would be to test whether custom fonts and SVG is supported and use suitable replacements. This would also help #13354 because the proposed country flags also use SVG.

In Tor Browser, some ways of checking if characters render display a popup dialog about allowing HTML canvas access. Let's not trigger a dialog like that if we can avoid it.

comment:9 Changed 2 years ago by irl

Resolution: wontfix
Status: needs_informationclosed

I would like Atlas to behave in the same way in all cases to reduce any bugs we may miss due to not testing with every security slider setting every time. Using Atlas with Tor Browser with High security is a use case we support, so I don't think we can switch to using vector icons for the sake of them looking nicer while breaking other use-cases and requirements.

Note: See TracTickets for help on using tickets.