Opened 3 years ago

Closed 3 years ago

#19547 closed defect (fixed)

Updating Pluggable Transport page(s)

Reported by: mrphs Owned by: Sebastian
Priority: Immediate Milestone:
Component: Webpages/Website Version:
Severity: Normal Keywords: Pluggable-Transports
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm updating PT pages, pushing the updates to PT branch of my website repo: nima/website.git

https://gitweb.torproject.org/nima/website.git/commit/?h=PT

Please review and merge.

Child Tickets

Change History (14)

comment:1 Changed 3 years ago by mrphs

Status: newneeds_review

comment:2 Changed 3 years ago by Sebastian

Why do the deprecated PTs list maintainers?

comment:3 Changed 3 years ago by Sebastian

The branch is based on staging instead of master, I cherry-picked the commit over. staging isn't ready to be merged to master currently.

comment:4 Changed 3 years ago by Sebastian

I wonder if we should point out google app engine as much as we do.

I'm not a native speaker but i think these Oxford commas aren't really Oxford commas. I thought you only put the comma before the conjunction if you had a list of at least three things.

But I've merged this so far, thanks for the patch. Let me know if you want to change anything wrt the above points, if you're happy just close this.

comment:5 Changed 3 years ago by Sebastian

Resolution: fixed
Status: needs_reviewclosed

Closing for now

comment:6 Changed 3 years ago by mrphs

Resolution: fixed
Status: closedreopened

I've made more changes, pls review and merge.

comment:7 Changed 3 years ago by mrphs

Status: reopenedneeds_review

comment:8 Changed 3 years ago by Sebastian

Priority: HighMedium

0542ebb2bc229e618851651dd63ac869c263babd:

+#Pluggable Transports
+RewriteRule ^PT/$ /docs/pluggable-transports [R=301,L]

NACK. Adding redirects without a very good reason is not scalable. Do you just want a shorter URL or am I missing anything?

362ecac51d3b4ee36c0562249a2f671be32ca31b:
The commit message talks about h2, the code has h3. Fine by me, tho.

1c3d67f34169832ee9beee5e214c152cf0fa4dfb:
Hrm. I think we should only add a redirect for projects/obfsproxy if at all, because the other pages have different content that isn't represented in the docs/pluggable-transports.

4998b989022f2dfcd7fd062e8e4175dd29fb99b2:

-<a href="<page projects/obfsproxy>"><img class="icon"
+<a href="<page /docs/pluggable-transports>"><img class="icon"

the <page> links shouldn't use /docs but rather just docs (repeated in other parts of the page)

Otherwise good

comment:9 in reply to:  8 Changed 3 years ago by mrphs

Replying to Sebastian:

0542ebb2bc229e618851651dd63ac869c263babd:

+#Pluggable Transports
+[wiki:RewriteRule] ^PT/$ /docs/pluggable-transports [R=301,L]

NACK. Adding redirects without a very good reason is not scalable. Do you just want a shorter URL or am I missing anything?

It's for the PT animation. At the end we need to send people to an address to learn more, and torproject.org/docs/pluggable-transports is too long for that.

362ecac51d3b4ee36c0562249a2f671be32ca31b:
The commit message talks about h2, the code has h3. Fine by me, tho.

ah sorry about that. I'll fix.

1c3d67f34169832ee9beee5e214c152cf0fa4dfb:
Hrm. I think we should only add a redirect for projects/obfsproxy if at all, because the other pages have different content that isn't represented in the docs/pluggable-transports.

It's linked in other places and the document is outdated. The transport itself is deprecated. It's on my todo list to add more info on that page.

4998b989022f2dfcd7fd062e8e4175dd29fb99b2:

-<a href="<page projects/obfsproxy>"><img class="icon"
+<a href="<page /docs/pluggable-transports>"><img class="icon"

the <page> links shouldn't use /docs but rather just docs (repeated in other parts of the page)

Right. I'll fix this real quick.

Otherwise good

Thank you!

comment:10 Changed 3 years ago by mrphs

rewrote history and pushed. pls review.

comment:11 Changed 3 years ago by Sebastian

I still don't think we should add redirects for stuff that's that isn't on that URL anymore. If other places link to outdated stuff, we should put a 410 or something into place or point out the content is removed. Otherwise this is OK modulo language fixes:

If connections to Tor network are being blocked by your ISP or country, follow this instructions:

should probably be

If your connection to the Tor network is being blocked, follow these instructions:

because it's shorter and more easily understandable without losing information.

   <img src="../images/PT/2016-07-how-to-use-PT.png"

use $(IMGROOT), the alt text repeats step three twice

Please no _blank links (especially not to local resources)

comment:12 Changed 3 years ago by Sebastian

merged the first two commits, btw

comment:13 Changed 3 years ago by mrphs

Priority: MediumImmediate

pushed changes. please review.

Last edited 3 years ago by mrphs (previous) (diff)

comment:14 Changed 3 years ago by Sebastian

Resolution: fixed
Status: needs_reviewclosed

merged with a couple of fixups

Note: See TracTickets for help on using tickets.