Opened 3 years ago

Last modified 13 months ago

#19552 new defect

Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

Reported by: andrea Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-unit-tests tor-control directory download
Cc: Actual Points: 4
Parent ID: Points: 2
Reviewer: nickm Sponsor: SponsorS-can

Description

It's hairy and complicated and different for every download status type to find out if / how many active attempts there are; we can do better.

Child Tickets

Attachments (1)

0001-Add-n-conns-downloading-to-download-GETINFO-queries-.patch (1.5 KB) - added by andrea 3 years ago.
Proposed controller spec patch

Download all attachments as: .zip

Change History (24)

comment:1 Changed 3 years ago by nickm

Keywords: tor-unit-tests TorCoreTeam201607 added
Sponsor: SponsorS-can
Status: newassigned

comment:2 Changed 3 years ago by andrea

This is going to end up just reporting how many active dirconns there are, I think; I've got the machinery to build lists of them for the download status queries, but the right approach to exposing more than a count is a way to provide a token usable with a more general connection-status query mechanism, and the existing control-port spec is pretty short on those. The only connection status query it seems to offer is /orconn-status to get a list of orconns. If we care about this perhaps we should consider building a more general-purpose mechanism, but I think adding "<n> downloads active" satisfies the original intent of this ticket.

comment:3 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added; TorCoreTeam201607 removed

No further code or documentation will be written in July, due to time itself. (Leaving needs_revision tickets as-is)

comment:4 Changed 3 years ago by andrea

Status update: mechanism for three out of four query types in my ticket19552 branch; still needs cert/signing key dirconn mechanism and to be wired up in control.c, and unit tests.

comment:5 Changed 3 years ago by andrea

Actual Points: 3

comment:6 Changed 3 years ago by andrea

Actual Points: 34

Branch now done except for control-spec-change-requiring bit (i.e. outputting info on dirconns for a download on the control port) and unit tests, but not yet uploaded since I'm away from my private key.

comment:7 Changed 3 years ago by andrea

Status: assignedneeds_review

Unit-tested and ready for review in my ticket19552_squashed branch.

comment:8 Changed 3 years ago by andrea

Attaching proposed spec patch

Changed 3 years ago by andrea

Proposed controller spec patch

comment:9 Changed 3 years ago by nickm

Keywords: review-group-8 added

comment:10 Changed 3 years ago by nickm

I put it at gitlab over here for review: https://gitlab.com/nickm_tor/tor/merge_requests/6/commits

comment:11 Changed 3 years ago by nickm

Reviewer: nickm
Status: needs_reviewneeds_revision

I've added a bunch of comments at the gitlab. Many are for issues you fixed later; only a few actually need changing.

Actual-review-points: .1

comment:12 Changed 3 years ago by nickm

Keywords: review-group-9 added; review-group-8 removed

comment:13 Changed 3 years ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

comment:14 Changed 3 years ago by nickm

These have sat in needs_revision for a few weeks at least. Removing from review-group-9, not adding to review-group-10.

comment:15 Changed 3 years ago by nickm

Keywords: review-group-9 removed

comment:16 Changed 3 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: unspecified

Triaged out on December 2016 from 030 to unspecified

comment:17 Changed 2 years ago by nickm

Keywords: nickm-deferred-20161005 removed

comment:18 Changed 2 years ago by nickm

Keywords: triage-out-030-201612 removed

comment:19 Changed 2 years ago by nickm

Keywords: TorCoreTeam201608 removed

comment:20 Changed 2 years ago by nickm

Keywords: tor-control directory download added

comment:21 Changed 18 months ago by dgoulet

Status: needs_revisionnew

comment:22 Changed 18 months ago by dgoulet

Owner: andrea deleted
Status: newassigned

comment:23 Changed 13 months ago by teor

Status: assignednew

Make everything that is assigned to no-one new again.

Note: See TracTickets for help on using tickets.