#19557 closed defect (fixed)

sandboxing crash while writing stats

Reported by: weasel Owned by:
Priority: High Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.4-rc
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With 19556 fixed, Tor now crashes while trying to write stats.

(Sandbox) Caught a bad syscall attempt (syscall open)
/usr/bin/tor(+0x150566)[0x7f5547fe3566]
/lib/x86_64-linux-gnu/libpthread.so.0(open64+0x2d)[0x7f55466611ed]
/lib/x86_64-linux-gnu/libpthread.so.0(open64+0x2d)[0x7f55466611ed]
/usr/bin/tor(tor_open_cloexec+0x40)[0x7f5547fcb410]
/usr/bin/tor(start_writing_to_file+0xf2)[0x7f5547fdd0f2]
/usr/bin/tor(+0x14a25b)[0x7f5547fdd25b]
/usr/bin/tor(+0x14a3a8)[0x7f5547fdd3a8]
/usr/bin/tor(write_to_data_subdir+0x4f)[0x7f5547f711ef]
/usr/bin/tor(rep_hist_hs_stats_write+0x185)[0x7f5547f0b5b5]
/usr/bin/tor(+0x3e318)[0x7f5547ed1318]
/usr/bin/tor(+0x576e0)[0x7f5547eea6e0]
/usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x7fc)[0x7f554751c3dc]
/usr/bin/tor(do_main_loop+0x274)[0x7f5547ed4ad4]
/usr/bin/tor(tor_main+0x1b45)[0x7f5547ed81e5]
/usr/bin/tor(main+0x19)[0x7f5547ed05c9]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7f55460c4b45]
/usr/bin/tor(+0x3d619)[0x7f5547ed0619]

Child Tickets

Change History (2)

comment:1 Changed 23 months ago by weasel

Status: newneeds_review

My bug19557 branch (which also includes bug19556) adds

OPEN_DATADIR2_SUFFIX("stats", "hidserv-stats", ".tmp");

which should hopefully fix this.

comment:2 Changed 23 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged.

Note: See TracTickets for help on using tickets.