Opened 4 years ago

Closed 3 years ago

#19564 closed enhancement (fixed)

SR: use macros to compute our base64 encoded length

Reported by: dgoulet Owned by:
Priority: Low Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-sr, easy, tor-03-unspecified-201612
Cc: Actual Points:
Parent ID: #19531 Points: 0.1
Reviewer: Sponsor:

Description

Ticket #19531 once done should be adding some macros to compute the length of encoded base64 string.

Let's use them for these in shared_random.h:

  • SR_COMMIT_BASE64_LEN
  • SR_REVEAL_BASE64_LEN
  • SR_SRV_VALUE_BASE64_LEN

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by dgoulet

Parent ID: #19531

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 3 years ago by catalyst

Proposed patch at https://gitlab.com/argonblue/tor/merge_requests/2 (the last commit).

comment:5 Changed 3 years ago by dgoulet

Status: newneeds_review

comment:6 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready

This will be merged through #21872. This lgtm! Thanks! Much MUCH MUCH cleaner now :)

comment:7 Changed 3 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.1.x-final

comment:8 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

21872 is merged, and this is too.

Note: See TracTickets for help on using tickets.