Missing break statement in RelayNetworkStatusImpl

Ugh, I just found a potential bug in the patch attached to #17824: The last switch case in RelayNetworkStatusImpl doesn't contain a break statement and hence falls through to the default case. This code is still in master. I didn't investigate yet what effects that has, but I feel it might break things.

added component::metrics/library owner::iwakeh parent::19398 priority::medium resolution::fixed severity::normal status::closed type::defect labels

We should probably wait with the 1.3.0 release until this bug is fixed, well, if it's a bug after all.

Trac:
Parent: N/A to #19398 (moved)

Hmm, there should be a (new) test failing for such a thing. It seems to be a bug.

If I should work on this (as it was my patch), just assign it to me. Or, in case you're at it because of the other changes please set it to assigned.

Are you available to work on this? If not, I'll work on it tomorrow. Thanks!

Trac:
Owner: karsten to iwakeh
Status: new to assigned

Actually, I'm lacking the test data, i.e. a valid network-status v2 document.

Reassigning and curiously waiting to review again :-)

Trac:
Owner: iwakeh to karsten

Oh, what's wrong with the descriptors in CollecTor's archive? https://collector.torproject.org/archive/relay-descriptors/statuses/

But I can work on this now, unless you grab it back very quickly. ;)

Trac:
Owner: karsten to iwakeh

Trac:
0002-Added-test-and-bugfix-for-RelayNetworkStatusImpl.patch

Thanks for the test data pointer :-)

patch attached, based on the earlier cobertura patch for #19574 (moved)

Trac:
Status: assigned to needs_review

Patch looks good. Pushed to my task-19574 branch, together with the following CHANGELOG entry:

   - Stop reporting "-----END .*-----" lines in v2 network statuses as
     unrecognized.

If you prefer something else, let me know. Otherwise, I'll push to master and close tomorrow. Thanks!

The changelog entry is fine.

I forgot to adapt the branch rate to 42% for cobertura check; it should be:

    <cobertura-check branchrate="0" totallinerate="31" totalbranchrate="42" >
      <regex pattern="org.torproject.descriptor.benchmark.*" branchrate="0" linerate="0"/>
    </cobertura-check>

Trac:
Status: needs_review to merge_ready

Changed the rate to 42 and pushed to master. Thanks! Closing.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

mentioned in issue #19574 (moved)