Opened 4 years ago

Closed 4 years ago

#19574 closed enhancement (fixed)

Clean up codebase before 1.3.0 release

Reported by: karsten Owned by: iwakeh
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: #19398 Points:
Reviewer: Sponsor:


We just ran out of tickets to be merged into 1.3.0, and I'd like to take this opportunity to make some general changes to the codebase before releasing. Things like:

  • moving all Java sources to src/main/java/,
  • adding a checkstyle task and fixing most of the style issues found by checkstyle, and
  • updating the copyright notice to 2016.

(I already started working on these things and will post a branch in a minute.)

What other bulk updates should we make before the 1.3.0 release?

Child Tickets

Attachments (1)

0001-Tweaked-file-structure-and-added-cobertura.patch (13.7 KB) - added by iwakeh 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by karsten

Status: newneeds_review

There, please review my branch task-19574.

comment:2 Changed 4 years ago by iwakeh

Thorough clean-up!
Looks fine.

The cobertura task could also be added now. Then, comments like

 /* TODO Write a test class. */
 public class BridgePoolAssignmentImpl extends DescriptorImpl

could be removed.

The coverage checks need to be set to the current value. So they fail if coverage is reduced by a change.

comment:3 Changed 4 years ago by karsten

Good idea. I'm currently distracted by something else, so if you'd want to grab this, please reassign the ticket. Otherwise I'll do it tomorrow. Thanks!

comment:4 Changed 4 years ago by iwakeh

Owner: changed from karsten to iwakeh
Status: needs_reviewassigned

comment:5 Changed 4 years ago by iwakeh

Status: assignedneeds_review

patch attached, please review.

comment:6 Changed 4 years ago by karsten

Looks great, no additions or change requests. Pushed to my branch. Anything else that should go into master before we test that a little and put out the release?

comment:7 Changed 4 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged together with the #19571 changes. Closing. Thanks!

Note: See TracTickets for help on using tickets.