Opened 4 years ago

Closed 4 years ago

#19578 closed defect (fixed)

Incorrect log message on mismatch ownership in check_private_dir

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201607
Cc: Actual Points: .1
Parent ID: #18902 Points: .1
Reviewer: Sponsor:

Description

our variable shadowing in check_private_dir results in an incorrect log message.

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by cypherpunks

For #18902 i solved the shadowing issue was simply removing the second definition of the pw variable. I believe this works because nothing uses pw outside the second if statement block that uses it.

What was incorrect about the log message?

comment:2 Changed 4 years ago by nickm

Actual Points: .1
Owner: set to nickm
Points: .1
Status: newaccepted

I think I got it actually fixed in the branch as merged. Thanks!

comment:3 Changed 4 years ago by nickm

Keywords: TorCoreTeam201607 added
Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.