Opened 3 years ago

Closed 3 years ago

#19609 closed defect (invalid)

Wrong version restriction for ADD_ONION_BASIC_AUTH

Reported by: drazvan Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Normal Keywords: controller
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

ADD_ONION_BASIC_AUTH appears to be restricted to Tor 0.2.9.1-alpha and above in version.py (https://gitweb.torproject.org/stem.git/tree/stem/version.py#n368) but correct version is 0.2.9.0-alpha (latest version in Tor Git).

It's probably a typo in version.py, needs to be 0.2.9.0 instead of 0.2.9.1.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by Sebastian

0.2.9.0-alpha is not a real version.

comment:2 Changed 3 years ago by atagar

Component: Core Tor/StemCore Tor/Tor

Hi drazvan, sending over to Nick for clarification. The spec says 0.2.9.1-alpha - happy to change if the spec needs correction.

https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n1536

comment:3 Changed 3 years ago by Sebastian

This doesn't make sense. 0.2.9.0 is not a released version, it doesn't exist. There's a tag for 0.2.9.0-root that doesn't have the feature.

comment:4 Changed 3 years ago by teor

Resolution: invalid
Status: newclosed

ClientAuth was added in git commit dcc11674, which is not in any released version of tor.
It's been merged to master, and was not backported to any previous release.
Therefore, the first release we can *guarantee* it will be in is 0.2.9.1-alpha.

(There are versions of 0.2.9.0-alpha-dev that don't have this feature. Therefore, stem can't rely on all versions labelled 0.2.9.0-alpha-dev having this feature.)

Note: See TracTickets for help on using tickets.