confirm to style guide

verify that metrics-lib complies to the rules. make necessary changes.

added component::metrics/library owner::iwakeh parent::19611 priority::medium resolution::implemented severity::normal status::closed type::task labels

Trac:
Owner: karsten to iwakeh
Status: new to assigned

maybe this can go into release 1.3.0, as most things are done.

I already fixed most of the issues found by checkstyle here. The remaining issues required more thoughts and maybe discussion. And I already prepared the 1.3.0 release in #19398 (moved). But if you prefer fixing most or even all issues, I'm happy to delay the 1.3.0 release. What do you think?

I'll attach a patch to #19398 (moved) that fixes all but three checkstyle complaints.

The two remaining switch-without-default definitely need new tests and probably discussion. These can be tackled on this issue, which now can wait for a release > 1.3.0.

The checkstyle complaints are gone (cf. #19398 (moved)).

The file structure and all code metrics are implemented according to the style guide.

Please review.

Trac:
Status: assigned to needs_review

With #19398 (moved) reviewed and merged, it sounds like we're done here, right?

Yes, we're done here. Thanks! Closing.

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed