Opened 3 years ago

Closed 3 years ago

#19612 closed task (implemented)

confirm to style guide

Reported by: iwakeh Owned by: iwakeh
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #19611 Points:
Reviewer: Sponsor:

Description

verify that metrics-lib complies to the rules.
make necessary changes.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by iwakeh

Owner: changed from karsten to iwakeh
Status: newassigned

comment:2 Changed 3 years ago by iwakeh

maybe this can go into release 1.3.0, as most things are done.

comment:3 Changed 3 years ago by karsten

I already fixed most of the issues found by checkstyle here. The remaining issues required more thoughts and maybe discussion. And I already prepared the 1.3.0 release in #19398. But if you prefer fixing most or even all issues, I'm happy to delay the 1.3.0 release. What do you think?

comment:4 Changed 3 years ago by iwakeh

I'll attach a patch to #19398 that fixes all but three checkstyle complaints.

The two remaining switch-without-default definitely need new tests and probably discussion.
These can be tackled on this issue, which now can wait for a release > 1.3.0.

comment:5 Changed 3 years ago by iwakeh

Status: assignedneeds_review

The checkstyle complaints are gone (cf. #19398).

The file structure and all code metrics are implemented according to the style guide.

Please review.

comment:6 Changed 3 years ago by karsten

With #19398 reviewed and merged, it sounds like we're done here, right?

comment:7 Changed 3 years ago by iwakeh

Resolution: implemented
Status: needs_reviewclosed

Yes, we're done here. Thanks!
Closing.

Note: See TracTickets for help on using tickets.