Comply to Metrics Java style guide

changed milestone to %ExoneraTor 1.0.0

added component::metrics/exonerator metrics-2017 milestone::ExoneraTor 1.0.0 owner::iwakeh parent::19611 priority::medium resolution::fixed severity::normal status::closed type::task labels

I'll grab this one, because nobody is working on ExoneraTor at the moment.

Trac:
Owner: N/A to karsten
Status: new to assigned

Please find my branch task-19624 with code style changes.

Trac:
Status: assigned to needs_review

Ah, I should have mentioned that the branch I pasted above is based on my task-19404 branch, so we should be sure that that one is okay, too, before merging to master.

The changes look fine and can be merged.

What's left according to our style guide:

• changing file structure even more
• adding a coverage task
• adding a test task and
• the first tiny test for verifying that test and coverage tasks work

Should there be a bin directory added to the standard file structure in order to have a place for scripts?

I could take over the open topics in order to familiarize myself with exonerator?

Trac:
Summary: java modules of Exonerator should coply to style guide to Exonerator should comply to Metrics Java style guide

Trac:
Status: needs_review to needs_revision

Replying to iwakeh:

The changes look fine and can be merged.

Great, thanks for looking! Merged.

What's left according to our style guide:

• changing file structure even more
• adding a coverage task
• adding a test task and
• the first tiny test for verifying that test and coverage tasks work

Agreed.

Should there be a bin directory added to the standard file structure in order to have a place for scripts?

Well, we could move scripts to such a directory, but I could also see us making those changes when we're changing the way ExoneraTor is executed. Ideally, we'd do this via sudo service exonerator start|stop|status|..., and that would include both the hourly updater and the (then Jetty-based) servlet.

I could take over the open topics in order to familiarize myself with exonerator?

Please do!

Trac:
Status: needs_revision to assigned
Owner: karsten to iwakeh

Please review the zero checkstyle complaints branch in my shiny new repo.

If things are ok, please set to assigned again. Restructuring, mini test, and coverage will follow.

Trac:
Status: assigned to needs_review

Looks good, merged! Thanks!

Thanks for the review.

Assigned second part.

Trac:
Status: needs_review to assigned

Trac:
Milestone: N/A to ExoneraTor 1.0.0

Keep summary as short and precise as possible.

Trac:
Summary: Exonerator should comply to Metrics Java style guide to Comply to Metrics Java style guide

Trac:
Keywords: N/A deleted, metrics-2018 added

Trac:
Keywords: metrics-2018 deleted, metrics-2017 added

Please review these checkstyle fixes.

Once this is merged the ticket should be closed, because all else will be part of ticket #21145 (moved).

Trac:
Status: assigned to needs_review

Please find another commit on the above branch that replaces the legacy commons lang version (catering to java 1.2) by lang3 (designed for Java 7 and up).

Both patches look good, merged. Thanks! Closing as requested.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #21145 (moved)

mentioned in issue #23549 (moved)