Opened 3 years ago

Closed 2 years ago

#19624 closed task (fixed)

Comply to Metrics Java style guide

Reported by: iwakeh Owned by: iwakeh
Priority: Medium Milestone: ExoneraTor 1.0.0
Component: Metrics/ExoneraTor Version:
Severity: Normal Keywords: metrics-2017
Cc: Actual Points:
Parent ID: #19611 Points:
Reviewer: Sponsor:

Description


Child Tickets

Change History (17)

comment:1 Changed 3 years ago by karsten

Owner: set to karsten
Status: newassigned

I'll grab this one, because nobody is working on ExoneraTor at the moment.

comment:2 Changed 3 years ago by karsten

Status: assignedneeds_review

Please find my branch task-19624 with code style changes.

comment:3 Changed 3 years ago by karsten

Ah, I should have mentioned that the branch I pasted above is based on my task-19404 branch, so we should be sure that that one is okay, too, before merging to master.

comment:4 Changed 3 years ago by iwakeh

Summary: java modules of Exonerator should coply to style guideExonerator should comply to Metrics Java style guide

The changes look fine and can be merged.

What's left according to our style guide:

  • changing file structure even more
  • adding a coverage task
  • adding a test task and
  • the first tiny test for verifying that test and coverage tasks work

Should there be a bin directory added to the standard file structure in order to have a place for scripts?

I could take over the open topics in order to familiarize myself with exonerator?

comment:5 Changed 3 years ago by iwakeh

Status: needs_reviewneeds_revision

comment:6 in reply to:  4 Changed 3 years ago by karsten

Replying to iwakeh:

The changes look fine and can be merged.

Great, thanks for looking! Merged.

What's left according to our style guide:

  • changing file structure even more
  • adding a coverage task
  • adding a test task and
  • the first tiny test for verifying that test and coverage tasks work

Agreed.

Should there be a bin directory added to the standard file structure in order to have a place for scripts?

Well, we could move scripts to such a directory, but I could also see us making those changes when we're changing the way ExoneraTor is executed. Ideally, we'd do this via sudo service exonerator start|stop|status|..., and that would include both the hourly updater and the (then Jetty-based) servlet.

I could take over the open topics in order to familiarize myself with exonerator?

Please do!

comment:7 Changed 3 years ago by iwakeh

Owner: changed from karsten to iwakeh
Status: needs_revisionassigned

comment:8 Changed 3 years ago by iwakeh

Status: assignedneeds_review

Please review the zero checkstyle complaints branch in my shiny new repo.

If things are ok, please set to assigned again. Restructuring, mini test, and coverage will follow.

comment:9 Changed 3 years ago by karsten

Looks good, merged! Thanks!

comment:10 Changed 3 years ago by iwakeh

Status: needs_reviewassigned

Thanks for the review.

Assigned second part.

comment:11 Changed 3 years ago by iwakeh

Milestone: ExoneraTor 1.0.0

comment:12 Changed 2 years ago by karsten

Summary: Exonerator should comply to Metrics Java style guideComply to Metrics Java style guide

Keep summary as short and precise as possible.

comment:13 Changed 2 years ago by karsten

Keywords: metrics-2018 added

comment:14 Changed 2 years ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:15 Changed 2 years ago by iwakeh

Status: assignedneeds_review

Please review these checkstyle fixes.

Once this is merged the ticket should be closed, because all else will be part of ticket #21145.

comment:16 Changed 2 years ago by iwakeh

Please find another commit on the above branch that replaces the legacy commons lang version (catering to java 1.2) by lang3 (designed for Java 7 and up).

comment:17 Changed 2 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Both patches look good, merged. Thanks! Closing as requested.

Note: See TracTickets for help on using tickets.