Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19639 closed defect (fixed)

Make sure extend_info_from_router is only called on servers

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: 029-proposed, CoreTorTeam201607
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

Currently, extend_info_from_router is only called for a relay's ORPort self-checks. Let's make sure it stays that way.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by teor

Status: newneeds_review

Please see my branch bug19639 on https://github.com/teor2345/tor.git for a fix to the function comment and a precautionary BUG macro.

There's no need for this to go in 0.2.8, but it would be nice to have it as a precaution in 0.2.9.

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.2.9.x-final
Reviewer: nickm
Status: needs_reviewneeds_revision

Actual-review-points: 0

Two problems.

  • BUG is for use in conditionals. In this context, use tor_assert_nonfatal.
  • router_skip_or_reachability is declared static in routerlist.c

comment:3 Changed 3 years ago by teor

Added a fixup to bug19639 that fixes these two issues, and compiles with no warnings.

comment:4 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Merging!

comment:5 Changed 3 years ago by teor

Resolution: implemented
Status: closedreopened

When I changed from BUG() to tor_assert_nonfatal(), I forgot to invert the condition.

Please see my branch bug19639-fix

comment:6 Changed 3 years ago by nickm

Resolution: fixed
Status: reopenedclosed

Thanks for catching that! Merged.

comment:7 Changed 3 years ago by teor

Actually, credit to isis for reporting the unintentionally obnoxious log messages on #tor-project.

Note: See TracTickets for help on using tickets.