Make sure extend_info_from_router is only called on servers

Currently, extend_info_from_router is only called for a relay's ORPort self-checks. Let's make sure it stays that way.

changed milestone to %Tor: 0.2.9.x-final

added 029-proposed CoreTorTeam201607 actualpoints::0.1 component::core tor/tor milestone::Tor: 0.2.9.x-final points::0.1 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed type::defect version::tor 0.2.8.1-alpha labels

Please see my branch bug19639 on https://github.com/teor2345/tor.git for a fix to the function comment and a precautionary BUG macro.

There's no need for this to go in 0.2.8, but it would be nice to have it as a precaution in 0.2.9.

Trac:
Status: new to needs_review

Actual-review-points: 0

Two problems.

• BUG is for use in conditionals. In this context, use tor_assert_nonfatal.
• router_skip_or_reachability is declared static in routerlist.c

Trac:
Status: needs_review to needs_revision
Milestone: Tor: 0.3.0.x-final to Tor: 0.2.9.x-final
Reviewer: N/A to nickm

Added a fixup to bug19639 that fixes these two issues, and compiles with no warnings.

Merging!

Trac:
Status: needs_revision to closed
Resolution: N/A to implemented

When I changed from BUG() to tor_assert_nonfatal(), I forgot to invert the condition.

Please see my branch bug19639-fix

Trac:
Resolution: implemented to N/A
Status: closed to reopened

Thanks for catching that! Merged.

Trac:
Resolution: N/A to fixed
Status: reopened to closed

Actually, credit to isis for reporting the unintentionally obnoxious log messages on #tor-project.

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#19639 (closed)