Changes between Initial Version and Version 17 of Ticket #19647


Ignore:
Timestamp:
Aug 29, 2018, 3:55:14 AM (10 months ago)
Author:
teor
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19647

    • Property Status changed from new to assigned
    • Property Parent ID changed from #17238 to #24033
    • Property Cc neel@… added
    • Property Summary changed from Descriptors should only contain printable ASCII to HS Descriptors should only contain UTF-8
    • Property Owner set to neel
    • Property Sponsor changed from to SponsorR-can
    • Property Milestone changed from Tor: 0.2.??? to Tor: unspecified
    • Property Keywords prop285 added; 030-proposed removed
  • Ticket #19647 – Description

    initial v17  
    33This seems to occur due to memory corruption.
    44
    5 So let's make sure that a non-ASCII check is done on:
     5So let's make sure that a ~~non-ASCII~~ UTF-8 check is done on:
    66* hidden services: unencrypted or encrypted descriptor
    77* HSDirs: encrypted descriptor
    88* clients: unencrypted or encrypted descriptor
    99
    10 This might require a spec change - it's likely implicit in the spec already.
     10See https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n45
    1111
    12 For completeness, the set of printable ASCII characters is defined in dir-spec.txt as:
    13 {{{
    14     NL = The ascii LF character (hex value 0x0a).
    15     KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'
    16     ArgumentChar ::= any printing ASCII character except NL.
    17     WS = (SP | TAB)+
    18 }}}
     12~~This might require a spec change - it's likely implicit in the spec already.~~
    1913
    20 Where I assume "printing ASCII" means "space to tilde", but we should also clarify that in the torspec.
     14~~For completeness, the set of printable ASCII characters is defined in dir-spec.txt ... Where I assume "printing ASCII" means "space to tilde", but we should also clarify that in the torspec.~~