Opened 16 months ago

Closed 4 months ago

#19648 closed defect (fixed)

Error in descriptor download log message

Reported by: teor Owned by: nickm
Priority: Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: easy, intro, review-group-20
Cc: Actual Points: 0
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description (last modified by teor)

When we only launch one descriptor download in the basic-min chutney network, we add one extra descriptor to the "n at a time" part of the log message. (There are only 3 descriptors in this network.)

Jul 08 12:30:51.000 [info] launch_descriptor_downloads: Launching 1 request for 3 microdescs, 4 at a time

Child Tickets

Change History (13)

comment:1 Changed 16 months ago by teor

Description: modified (diff)

comment:2 Changed 11 months ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 10 months ago by neerajbattan

Do we always get descriptors+1?

comment:4 in reply to:  3 Changed 10 months ago by teor

Replying to neerajbattan:

Do we always get descriptors+1?

No, I think it only happens for small values of descriptor, but we should check that.

comment:5 Changed 10 months ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 5 months ago by nickm

Actual Points: 0
Milestone: Tor: unspecifiedHTTPS-E 3.2.2
Status: newneeds_review
Summary: Off-by-one error in descriptor download log messageError in descriptor download log message

This is actually a "less than 4 error", not an off by one error.

Fix in branch bug19648 in my public repository.

comment:7 Changed 5 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 4 months ago by nickm

Milestone: HTTPS-E 3.2.2Tor: 0.3.2.x-final

comment:9 Changed 4 months ago by nickm

Keywords: review-group-20 added

comment:10 Changed 4 months ago by nickm

Owner: set to nickm
Status: needs_reviewassigned

setting owner

comment:11 Changed 4 months ago by nickm

Status: assignedneeds_review

comment:12 Changed 4 months ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me.

comment:13 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master; thank you!

Note: See TracTickets for help on using tickets.