Opened 3 years ago

Last modified 2 years ago

#19656 new defect

Shared random state doesn't expire when clock changes?

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-sr tor-dirauth expiration
Cc: dgoulet, asn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

My test directory authority Evelyn was offline / asleep for a day or so.

When it came back online, it seemed to have state from a previous shared random round:
(Log times are UTC+10)

Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from 4CAEC248004A0DC6CE86EBD5F608C9B05500C70C in commit phase.
Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from 5604E1632E4583D6A43C6A56C16412228E0AF12A in commit phase.
Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from 587B958421F6952069C5853AF42F5A466DC6AD16 in commit phase.
Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from B058CA27CFCF0BDF09119759463C7607EE0C1CC1 in commit phase.
Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from E11AA24864B3CD504EF951090C351DBD96BE68F4 in commit phase.
Jul 09 20:52:31.000 [info] should_keep_commit(): SR: Received altered commit from ED8ABBE6A11336AE711926FD7C98948AB9FE96D7 in commit phase.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by teor

The messages started after Evelyn got a network connection back after this log message:
Jul 09 17:33:59.000 [info] sr_state_update(): SR: State prepared for upcoming voting period (2016-07-09 08:00:00). Upcoming phase is commit (counters: 9 commit & 0 reveal rounds).

And they've kept going up until this message, which is the latest one:
Jul 09 21:00:01.000 [info] sr_state_update(): SR: State prepared for upcoming voting period (2016-07-09 12:00:00). Upcoming phase is reveal (counters: 12 commit & 1 reveal rounds).

comment:2 Changed 3 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:3 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:4 Changed 3 years ago by dgoulet

Keywords: tor-hs isaremoved removed

comment:5 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 2 years ago by nickm

Cc: dgoulet asn added
Keywords: tor-dirauth expiration added
Note: See TracTickets for help on using tickets.