Opened 3 years ago

Closed 3 years ago

#19680 closed enhancement (implemented)

Pep8 renamed to pycodestyle

Reported by: atagar Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Stem Version:
Severity: Minor Keywords: testing, easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We use pyflakes and pep8 during our tests. Recently the pep8 project renamed itself to pycodestyle. We should update Stem to handle both names.

Child Tickets

Attachments (1)

test_output.txt (1.5 MB) - added by neel 3 years ago.
Unit Testing (run with ./run_tests.py --unit --integ)

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by neel

Attachment: test_output.txt added

Unit Testing (run with ./run_tests.py --unit --integ)

comment:1 Changed 3 years ago by neel

I have created a patch and uploaded it to GitHub Gist at this URL: https://gist.github.com/neelchauhan/849ef8eb7e15fb8370c653abcc5ab4e2

(I used GitHub Gist because Trac marked this patch as "spam".)

Sorry if there are mistakes with this patch, but this is my first to Stem.

comment:2 Changed 3 years ago by atagar

Resolution: implemented
Status: newclosed

Thanks neel! Pushed with a few small changes to fix our testing configuration and provide backward compatibility.

Patch is much appreciated!

Note: See TracTickets for help on using tickets.