Opened 3 years ago

Closed 3 years ago

#19727 closed defect (fixed)

correct exitlist

Reported by: iwakeh Owned by:
Priority: Medium Milestone: CollecTor 1.0.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: ctip
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Make exitlists url configurable and correct current setting:

The current setting http://exitlist.torproject.org/exit-addresses is wrong and should be changed to https://check.torproject.org/exit-addresses.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by karsten

You're right, I still have that non-staged change on the CollecTor server, because that URL changed a few times in the past and I didn't know how permanent the current change would be, and then I forgot. Oops. Do you have a patch?

comment:2 Changed 3 years ago by iwakeh

Status: newneeds_review

Please review the implementation.

Clean compile, tests pass, coverage stays the same, no checkstyle complaints added.

This is a good example for adding a property setting with a new class type.

comment:3 Changed 3 years ago by karsten

Patch looks good, but I'm having trouble testing it. It's probably something unrelated, but I don't know what. Do you have an idea?

~/src/collector$ java -jar collector-0.9.0-dev.jar
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.SecurityException: Invalid signature file digest for Manifest main attributes
	at sun.security.util.SignatureFileVerifier.processImpl(SignatureFileVerifier.java:284)
	at sun.security.util.SignatureFileVerifier.process(SignatureFileVerifier.java:238)
	at java.util.jar.JarVerifier.processEntry(JarVerifier.java:273)
	at java.util.jar.JarVerifier.update(JarVerifier.java:228)
	at java.util.jar.JarFile.initializeVerifier(JarFile.java:383)
	at java.util.jar.JarFile.getInputStream(JarFile.java:450)
	at sun.misc.URLClassPath$JarLoader$2.getInputStream(URLClassPath.java:940)
	at sun.misc.Resource.cachedInputStream(Resource.java:77)
	at sun.misc.Resource.getByteBuffer(Resource.java:160)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:454)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:495)

comment:4 Changed 3 years ago by iwakeh

That's probably what I patched here.

comment:5 Changed 3 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Yes, that patch makes it work just fine. I pushed your task-19727 branch but didn't push that commit 1426040 yet which we should merge soon as part of the other branch. Closing. Thanks!

Note: See TracTickets for help on using tickets.