Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#19730 closed enhancement (implemented)

Metrics web java modules should use Java 7 throughout

Reported by: iwakeh Owned by:
Priority: High Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

this includes code adaption to newer java features.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by karsten

Looks like we already made some progress in this direction in #21535. What remains to be done? Switch-on-String? What else?

comment:2 Changed 3 years ago by karsten

Also try-with-resources and multiple exceptions. What else?

comment:3 Changed 2 years ago by karsten

Milestone: Metrics 1.0.0
Priority: MediumHigh
Status: newneeds_review

Please review my task-19730 commit. Raising priority a bit, because this is blocking other changes to the code base without risking a major merge mess. (Thanks!)

comment:4 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine. Good to move this.

Next time the code gets touched logging should be added and all the System.err.print* and e.printStackTrace should be replaced.

comment:5 Changed 2 years ago by karsten

Resolution: implemented
Status: merge_readyclosed

Awesome, thanks for the quick review! Pushed to master, deploying on meronense either later today or over the weekend. (Also agreeing about System.err.print*, plus we'll want to change all places where we're using different logging frameworks than slf4j. But that can happen independently of this ticket.) Closing. Thanks again!

comment:6 Changed 2 years ago by karsten

I just pushed another small commit to master that puts the constructors back which were actually still in use. Oops.

Note: See TracTickets for help on using tickets.